components/safe_browsing_db/safe_browsing_api_handler_util.h - Issue 1579403002: Move remote_db_manager into the safe_browsing_db component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/safe_browsing_api_handler_util.h

Issue 1579403002: Move remote_db_manager into the safe_browsing_db component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a gn dep on safe_browsing_db_mobile Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/components_tests.gyp ('K') | « components/safe_browsing_db/safe_browsing_api_handler_unittest.cc ('k') | components/safe_browsing_db/safe_browsing_api_handler_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/safe_browsing_api_handler_util.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_api_handler_util.h b/components/safe_browsing_db/safe_browsing_api_handler_util.h

similarity index 87%

rename from chrome/browser/safe_browsing/safe_browsing_api_handler_util.h

rename to components/safe_browsing_db/safe_browsing_api_handler_util.h

index 07ed8357b861af2bdcc26a9a766eed2a60c09c23..5733c664a51143d028e39afc25da4148522ec32d 100644

--- a/chrome/browser/safe_browsing/safe_browsing_api_handler_util.h

+++ b/components/safe_browsing_db/safe_browsing_api_handler_util.h

@@ -4,12 +4,12 @@

// Helper functions for SafeBrowsingApiHandlerImpl. Separated out for tests.

-#ifndef CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_API_HANDLER_UTIL_H_

-#define CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_API_HANDLER_UTIL_H_

+#ifndef COMPONENTS_SAFE_BROWSING_DB_SAFE_BROWSING_API_HANDLER_UTIL_H_

+#define COMPONENTS_SAFE_BROWSING_DB_SAFE_BROWSING_API_HANDLER_UTIL_H_

#include <string>

-#include "chrome/browser/safe_browsing/safe_browsing_util.h"

+#include "components/safe_browsing_db/util.h"

Nathan Parker 2016/01/20 23:26:54 This points to a different file, not one that you'

vakh (use Gerrit instead) 2016/01/21 01:36:46 chrome/browser/safe_browsing/safe_browsing_util.h

namespace safe_browsing {

@@ -55,4 +55,4 @@ UmaRemoteCallResult ParseJsonToThreatAndPB(const std::string& metadata_str,

std::string* metadata_pb_str);

} // namespace safe_browsing

-#endif // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_API_HANDLER_UTIL_H_

+#endif // COMPONENTS_SAFE_BROWSING_DB_SAFE_BROWSING_API_HANDLER_UTIL_H_