Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: components/safe_browsing_db.gypi

Issue 1579403002: Move remote_db_manager into the safe_browsing_db component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a gn dep on safe_browsing_db_mobile Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db.gypi
diff --git a/components/safe_browsing_db.gypi b/components/safe_browsing_db.gypi
index 009543edf5186661c83175f59ad5f98f795e13a8..6ae736fafe2f0c362357e8a253303388c61b231f 100644
--- a/components/safe_browsing_db.gypi
+++ b/components/safe_browsing_db.gypi
@@ -5,8 +5,8 @@
{
'targets': [
{
- # GN version: //components/safe_browsing_db
- 'target_name': 'safe_browsing_db',
+ # GN version: //components/safe_browsing_db:safe_browsing_db_shared
+ 'target_name': 'safe_browsing_db_shared',
'type': 'static_library',
'dependencies': [
'../base/base.gyp:base',
@@ -32,6 +32,44 @@
'msvs_disabled_warnings': [4267, ],
},
{
+ # GN version: //components/safe_browsing_db
+ 'target_name': 'safe_browsing_db',
+ 'type': 'static_library',
+ 'dependencies': [
+ ':safe_browsing_db_shared',
+ ],
+ 'sources': [
+ ],
+ 'include_dirs': [
+ '..',
+ ],
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ 'msvs_disabled_warnings': [4267, ],
+ },
+ {
+ # GN version: //components/safe_browsing_db:safe_browsing_db_mobile
+ 'target_name': 'safe_browsing_db_mobile',
+ 'type': 'static_library',
+ 'dependencies': [
+ ':safe_browsing_db_shared',
+ ':safe_browsing_metadata_proto',
+ ],
+ 'sources': [
+ # Note: sources list duplicated in GN build.
+ 'safe_browsing_db/remote_database_managerh',
+ 'safe_browsing_db/remote_database_manager.cc',
+ 'safe_browsing_db/safe_browsing_api_handler.h',
+ 'safe_browsing_db/safe_browsing_api_handler.cc',
+ 'safe_browsing_db/safe_browsing_api_handler_util.h',
+ 'safe_browsing_db/safe_browsing_api_handler_util.cc',
+ ],
+ 'include_dirs': [
+ '..',
+ ],
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ 'msvs_disabled_warnings': [4267, ],
+ },
+ {
# GN version: //components/safe_browsing_db:proto
# Protobuf compiler / generator for the Safe Browsing protocol buffer.
'target_name': 'safebrowsing_proto',
@@ -44,6 +82,19 @@
'includes': [ '../build/protoc.gypi' ]
},
{
+ # Protobuf compiler / generator for the safebrowsing full hash metadata
+ # protocol buffer.
+ # GN version: //components/safe_browsing_db:metadata_proto
+ 'target_name': 'safe_browsing_metadata_proto',
+ 'type': 'static_library',
+ 'sources': [ 'safe_browsing_db/metadata.proto' ],
+ 'variables': {
+ 'proto_in_dir': 'safe_browsing_db',
+ 'proto_out_dir': 'components/safe_browsing_db',
+ },
+ 'includes': [ '../build/protoc.gypi' ]
+ },
+ {
# GN version: //components/safe_browsing_db:test_database_manager
'target_name': 'test_database_manager',
'type': 'static_library',

Powered by Google App Engine
This is Rietveld 408576698