Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Side by Side Diff: components/components_tests.gyp

Issue 1579403002: Move remote_db_manager into the safe_browsing_db component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a gn dep on safe_browsing_db_mobile Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # This turns on e.g. the filename-based detection of which 7 # This turns on e.g. the filename-based detection of which
8 # platforms to include source files on (e.g. files ending in 8 # platforms to include source files on (e.g. files ending in
9 # _mac.h or _mac.cc are only compiled on MacOSX). 9 # _mac.h or _mac.cc are only compiled on MacOSX).
10 'chromium_code': 1, 10 'chromium_code': 1,
(...skipping 1242 matching lines...) Expand 10 before | Expand all | Expand 10 after
1253 '../build/linux/system.gyp:ssl', 1253 '../build/linux/system.gyp:ssl',
1254 ], 1254 ],
1255 }, { 1255 }, {
1256 'dependencies': [ 1256 'dependencies': [
1257 '../third_party/nss/nss.gyp:nspr', 1257 '../third_party/nss/nss.gyp:nspr',
1258 '../third_party/nss/nss.gyp:nss', 1258 '../third_party/nss/nss.gyp:nss',
1259 ], 1259 ],
1260 }], 1260 }],
1261 ], 1261 ],
1262 }], 1262 }],
1263 ['safe_browsing == 2 and OS != "ios"', {
1264 'dependencies': [
1265 'components.gyp:safe_browsing_db_mobile',
1266 ],
1267 'sources': [
1268 'safe_browsing_db/remote_database_manager_unittest.cc',
Nathan Parker 2016/01/20 23:26:54 Can we specify a target here rather than individua
vakh (use Gerrit instead) 2016/01/21 01:36:46 Not sure if we can specify targets for sources. Th
blundell 2016/01/21 08:51:27 I think it would be more in the spirit of how thin
vakh (use Gerrit instead) 2016/01/21 18:48:46 Done.
1269 'safe_browsing_db/safe_browsing_api_handler_unittest.cc',
1270 ],
1271 }],
1263 ], 1272 ],
1264 }, { # 'OS == "ios"' 1273 }, { # 'OS == "ios"'
1265 'sources': [ 1274 'sources': [
1266 'webp_transcode/webp_decoder_unittest.mm', 1275 'webp_transcode/webp_decoder_unittest.mm',
1267 'webp_transcode/webp_network_client_unittest.mm', 1276 'webp_transcode/webp_network_client_unittest.mm',
1268 ], 1277 ],
1269 'sources/': [ 1278 'sources/': [
1270 # Exclude all tests that depends on //content (based on layered- 1279 # Exclude all tests that depends on //content (based on layered-
1271 # component directory structure). 1280 # component directory structure).
1272 ['exclude', '^[^/]*/content/'], 1281 ['exclude', '^[^/]*/content/'],
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
1883 'dependencies': [ 1892 'dependencies': [
1884 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', 1893 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
1885 ], 1894 ],
1886 }], 1895 }],
1887 ], 1896 ],
1888 }, 1897 },
1889 ], 1898 ],
1890 }], 1899 }],
1891 ], 1900 ],
1892 } 1901 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698