Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 1579343003: Resolve issues with websocket compression. (Closed)

Created:
4 years, 11 months ago by butlermatt
Modified:
4 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, kaendfinger
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resolve issues with websocket compression. Always reuse encoder/decoder otherwise we send partial frames before all data is added properly. Also reduces redundant allocations. Websocket: Only set compression flag if not a continuation frame Continuation frames should inherit compression settings from previous frame. BUG=#25317 Patch by Matthew Butler <butler.matthew@gmail.com>;. R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/a72ddf3a9d4eaa023e966cb39b52c4d78bb2186c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -22 lines) Patch
M sdk/lib/io/websocket_impl.dart View 3 chunks +10 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
butlermatt
Patch resolves issues with Websocket Compression. All autobahn tests for sections 12.*.* and 13.*.* from ...
4 years, 11 months ago (2016-01-13 18:05:44 UTC) #1
Søren Gjesse
LGTM, thanks for fixing this
4 years, 11 months ago (2016-01-14 09:44:18 UTC) #3
Søren Gjesse
4 years, 11 months ago (2016-01-14 09:44:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a72ddf3a9d4eaa023e966cb39b52c4d78bb2186c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698