Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1579333003: Make the error message in WorkerThreadableLoader more developer-friendly. (Closed)

Created:
4 years, 11 months ago by horo
Modified:
4 years, 11 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the error message in WorkerThreadableLoader more developer-friendly. BUG=574499 Committed: https://crrev.com/3b34b0987eea3325a936f6554d2532bff6e4e9a3 Cr-Commit-Position: refs/heads/master@{#369321}

Patch Set 1 #

Total comments: 2

Patch Set 2 : incorporated kinuko's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
horo
kinuko@ Could you please review this?
4 years, 11 months ago (2016-01-13 07:04:17 UTC) #2
kinuko
lgtm, could you also comment the proposed text on the issue thread before landing (so ...
4 years, 11 months ago (2016-01-13 07:12:55 UTC) #3
kinuko
https://codereview.chromium.org/1579333003/diff/1/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp File third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp (right): https://codereview.chromium.org/1579333003/diff/1/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp#newcode150 third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp:150: didFail(ResourceError(errorDomainBlinkInternal, 0, request.url().string(), "The parent document page has being ...
4 years, 11 months ago (2016-01-13 07:13:11 UTC) #4
horo
https://codereview.chromium.org/1579333003/diff/1/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp File third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp (right): https://codereview.chromium.org/1579333003/diff/1/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp#newcode150 third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp:150: didFail(ResourceError(errorDomainBlinkInternal, 0, request.url().string(), "The parent document page has being ...
4 years, 11 months ago (2016-01-13 08:33:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579333003/20001
4 years, 11 months ago (2016-01-14 02:12:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 04:07:27 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 04:10:09 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b34b0987eea3325a936f6554d2532bff6e4e9a3
Cr-Commit-Position: refs/heads/master@{#369321}

Powered by Google App Engine
This is Rietveld 408576698