Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 1579303002: fix generic function expressions, part of #25175 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index f709d561fd01fbaee3309b95f92c615b2c09aeff..6cf56ac95b4c75ca06f604ebdceb307c61a64218 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -3100,10 +3100,6 @@ class ElementBuilder extends RecursiveAstVisitor<Object> {
if (_functionTypesToFix != null) {
_functionTypesToFix.add(element);
} else {
- // TODO(jmesserly): for local functions inside of top-level generic
- // functions, this is probably not right. The function type should be set
- // after the enclosingElement is set, otherwise we won't be able to
- // substitute those type parameters later.
element.type = new FunctionTypeImpl(element);
}
element.hasImplicitReturnType = true;

Powered by Google App Engine
This is Rietveld 408576698