Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1579303002: fix generic function expressions, part of #25175 (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org, Paul Berry
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M pkg/analyzer/lib/src/dart/element/type.dart View 2 chunks +17 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
this makes typeArguments lazy, similar to Paul's recent fix for typeParameters
4 years, 11 months ago (2016-01-12 22:07:01 UTC) #2
Leaf
lgtm https://codereview.chromium.org/1579303002/diff/1/pkg/analyzer/test/generated/resolver_test.dart File pkg/analyzer/test/generated/resolver_test.dart (right): https://codereview.chromium.org/1579303002/diff/1/pkg/analyzer/test/generated/resolver_test.dart#newcode13047 pkg/analyzer/test/generated/resolver_test.dart:13047: var lambdaCall = (/*<E>*/(/*=E*/ e) => e)/*<int>*/(3); Can ...
4 years, 11 months ago (2016-01-12 23:56:02 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/1579303002/diff/1/pkg/analyzer/test/generated/resolver_test.dart File pkg/analyzer/test/generated/resolver_test.dart (right): https://codereview.chromium.org/1579303002/diff/1/pkg/analyzer/test/generated/resolver_test.dart#newcode13047 pkg/analyzer/test/generated/resolver_test.dart:13047: var lambdaCall = (/*<E>*/(/*=E*/ e) => e)/*<int>*/(3); On 2016/01/12 ...
4 years, 11 months ago (2016-01-13 00:03:18 UTC) #4
Jennifer Messerly
4 years, 11 months ago (2016-01-13 00:05:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
351ccc586fd4a69a4baf565cd3efd2655fcdd788 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698