Issue 15793016: Make TestRenderWidgetHostView delete itself like the other RenderWidgetHostViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15793016: Make TestRenderWidgetHostView delete itself like the other RenderWidgetHostViews. (Closed)

Created:
7 years, 6 months ago by Jeffrey Yasskin

Modified:
7 years, 6 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make TestRenderWidgetHostView delete itself like the other RenderWidgetHostViews. This avoids the need for special-case code in tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204456

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -15 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_guest_unittest.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.cc	View	4 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/15793016/1

7 years, 6 months ago (2013-06-05 19:34:49 UTC) #2

Message was sent while issue was closed.

Change committed as 204456

Expand Messages | Collapse Messages