Issue 15793014: Use native_client/src/public/ for IMC headers

Issue 15793014: Use native_client/src/public/ for IMC headers (Closed)

Created:
7 years, 6 months ago by Roland McGrath

Modified:
7 years, 6 months ago

Reviewers:
dmichael (off chromium), Mark Seaborn

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use native_client/src/public/ for IMC headers The preferred way to get the header files for NaCl's IMC layer has changed. The NaClImcMsgIoVec and NaClImcMsgHdr structs now use the NaclAbi prefix. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3464 TEST= R=dmichael@chromium.org, mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204359

Patch Set 2 : add missing ipc/DEPS #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -19 lines)			Patch
A	ipc/DEPS	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ipc/ipc_channel_nacl.cc	View		4 chunks	+10 lines, -6 lines	0 comments	Download
M	ppapi/native_client/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/tests/nacl_browser/fault_injection/fault_pm_nameservice_test.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	ppapi/native_client/tests/nacl_browser/manifest_file/pm_manifest_file_test.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/native_client/tests/nacl_browser/manifest_file/pm_pre_init_manifest_file_test.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/native_client/tests/nacl_browser/nameservice/pm_nameservice_test.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

lgtm, thanks for this! https://codereview.chromium.org/15793014/diff/1/ipc/ipc_channel_nacl.cc File ipc/ipc_channel_nacl.cc (right): https://codereview.chromium.org/15793014/diff/1/ipc/ipc_channel_nacl.cc#newcode23 ipc/ipc_channel_nacl.cc:23: #include "native_client/src/public/imc_types.h" (nit: You'll have ...

7 years, 6 months ago (2013-06-05 17:08:17 UTC) #2

Roland McGrath

On 2013/06/05 17:08:17, dmichael wrote: > lgtm, thanks for this! > > https://codereview.chromium.org/15793014/diff/1/ipc/ipc_channel_nacl.cc > File ...

7 years, 6 months ago (2013-06-05 17:10:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcgrathr@chromium.org/15793014/7001

7 years, 6 months ago (2013-06-05 18:47:51 UTC) #4

Message was sent while issue was closed.

Change committed as 204359

Expand Messages | Collapse Messages