Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 15793006: Fix LStoreKeyed error when tracing instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added an assert Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 445
446 void LStoreKeyed::PrintDataTo(StringStream* stream) { 446 void LStoreKeyed::PrintDataTo(StringStream* stream) {
447 elements()->PrintTo(stream); 447 elements()->PrintTo(stream);
448 stream->Add("["); 448 stream->Add("[");
449 key()->PrintTo(stream); 449 key()->PrintTo(stream);
450 if (hydrogen()->IsDehoisted()) { 450 if (hydrogen()->IsDehoisted()) {
451 stream->Add(" + %d] <-", additional_index()); 451 stream->Add(" + %d] <-", additional_index());
452 } else { 452 } else {
453 stream->Add("] <- "); 453 stream->Add("] <- ");
454 } 454 }
455 value()->PrintTo(stream); 455
456 if (value() == NULL) {
457 ASSERT(hydrogen()->IsConstantHoleStore() &&
458 hydrogen()->value()->representation().IsDouble());
459 stream->Add("<the hole(nan)>");
460 } else {
461 value()->PrintTo(stream);
462 }
456 } 463 }
457 464
458 465
459 void LStoreKeyedGeneric::PrintDataTo(StringStream* stream) { 466 void LStoreKeyedGeneric::PrintDataTo(StringStream* stream) {
460 object()->PrintTo(stream); 467 object()->PrintTo(stream);
461 stream->Add("["); 468 stream->Add("[");
462 key()->PrintTo(stream); 469 key()->PrintTo(stream);
463 stream->Add("] <- "); 470 stream->Add("] <- ");
464 value()->PrintTo(stream); 471 value()->PrintTo(stream);
465 } 472 }
(...skipping 2307 matching lines...) Expand 10 before | Expand all | Expand 10 after
2773 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2780 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2774 LOperand* object = UseRegister(instr->object()); 2781 LOperand* object = UseRegister(instr->object());
2775 LOperand* index = UseTempRegister(instr->index()); 2782 LOperand* index = UseTempRegister(instr->index());
2776 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2783 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2777 } 2784 }
2778 2785
2779 2786
2780 } } // namespace v8::internal 2787 } } // namespace v8::internal
2781 2788
2782 #endif // V8_TARGET_ARCH_IA32 2789 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698