WebGL 2: remove incorrect enum value for buffer in clearBuffer

WebGL 2: remove incorrect enum value for buffer in clearBuffer

BUG=295792
Committed: https://crrev.com/a43d39ad0048c11bda032bfefd5cc6d8dbd6dc7b
Cr-Commit-Position: refs/heads/master@{#369343}

[yunchao, 2016-01-13 05:44:23]

yunchao.he@intel.com changed reviewers:
+ bajones@chromium.org, kbr@chromium.org, qiankun.miao@intel.com,
zmo@chromium.org

[yunchao, 2016-01-13 05:44:23]

A small change. PTAL.

When I fix fbo related bugs, I found this bug. I read the WebGL 2 spec, GLES 3.0
spec and OGL 4.2 spec, none of them support FRONT, BACK, FRONT_AND_BACK for
buffer argument in clearBuffer.

[qiankun, 2016-01-13 06:11:36]

https://codereview.chromium.org/1579253003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(left):

https://codereview.chromium.org/1579253003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:1610:
case GL_FRONT_AND_BACK:
INVALID_EUNUM should be genereated for the invalid buffer. See Page 190 in ES
3.0.4 spec: https://www.khronos.org/registry/gles/specs/3.0/es_spec_3.0.4.pdf.

I think you can add tests to validate this.

[yunchao, 2016-01-13 07:52:18]

https://codereview.chromium.org/1579253003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(left):

https://codereview.chromium.org/1579253003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:1610:
case GL_FRONT_AND_BACK:
On 2016/01/13 06:11:35, qiankun wrote:
> INVALID_EUNUM should be genereated for the invalid buffer. See Page 190 in ES
> 3.0.4 spec: https://www.khronos.org/registry/gles/specs/3.0/es_spec_3.0.4.pdf.
> 
> I think you can add tests to validate this.

It is not possible to expose the error by adding webgl conformance test for this
case, because the command buffer has validation code to verify the argument
'buffer'. Command buffer service side can report INVALID_ENUM against
FRONT/BACK/FRONT_AND_BACK.

However, validateClearBuffer() is necessary to verify the 'size' argument. We
can not remove this function.

[Zhenyao Mo, 2016-01-14 00:21:28]

lgtm

[yunchao, 2016-01-14 01:38:11]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2016-01-14 01:41:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579253003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579253003/1

[commit-bot: I haz the power, 2016-01-14 03:49:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 03:49:34]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)

[yunchao, 2016-01-14 03:53:00]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-14 03:55:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579253003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579253003/1

[commit-bot: I haz the power, 2016-01-14 05:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 05:41:54]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-01-14 05:42:25]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2016-01-14 05:42:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579253003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579253003/1

[commit-bot: I haz the power, 2016-01-14 05:47:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-14 05:48:35]

Description was changed from

==========
WebGL 2: remove incorrect enum value for buffer in clearBuffer

BUG=295792
==========

to

==========
WebGL 2: remove incorrect enum value for buffer in clearBuffer

BUG=295792

Committed: https://crrev.com/a43d39ad0048c11bda032bfefd5cc6d8dbd6dc7b
Cr-Commit-Position: refs/heads/master@{#369343}
==========

[commit-bot: I haz the power, 2016-01-14 05:48:36]

Patchset 1 (id:??) landed as
https://crrev.com/a43d39ad0048c11bda032bfefd5cc6d8dbd6dc7b
Cr-Commit-Position: refs/heads/master@{#369343}