Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1579223004: Revert of [cq] Keep presubmit trybots and cq automatically in sync. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [cq] Keep presubmit trybots and cq automatically in sync. (patchset #1 id:1 of https://codereview.chromium.org/1580193004/ ) Reason for revert: Doesn't work with triggered bots. Waiting for this fix: https://codereview.chromium.org/1587893003/ Original issue's description: > [cq] Keep presubmit trybots and cq automatically in sync. > > Code copied 1:1 from chromium. > > BUG=chromium:565952 > LOG=n > NOTRY=true > > Committed: https://crrev.com/039dce1e355be6422c672badef5f3895f3b16ead > Cr-Commit-Position: refs/heads/master@{#33264} TBR=tandrii@chromium.org,kjellander@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:565952 Committed: https://crrev.com/3b6f913fe73a333e707e698914d65fe16345dfa8 Cr-Commit-Position: refs/heads/master@{#33284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M PRESUBMIT.py View 1 chunk +22 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Achenbach
Created Revert of [cq] Keep presubmit trybots and cq automatically in sync.
4 years, 11 months ago (2016-01-14 08:00:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579223004/1
4 years, 11 months ago (2016-01-14 08:00:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 08:00:57 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b6f913fe73a333e707e698914d65fe16345dfa8 Cr-Commit-Position: refs/heads/master@{#33284}
4 years, 11 months ago (2016-01-14 08:01:13 UTC) #5
kjellander_chromium
4 years, 11 months ago (2016-01-14 08:27:27 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698