Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1579223003: Remove remaining users of draw*Rect calls (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -71 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 7 chunks +28 lines, -21 lines 1 comment Download
M src/gpu/GrDrawTarget.h View 1 chunk +0 lines, -30 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +5 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
joshualitt
this was easier than I thought
4 years, 11 months ago (2016-01-13 18:54:40 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1579223003/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/1579223003/diff/1/src/gpu/GrClipMaskManager.cpp#newcode50 src/gpu/GrClipMaskManager.cpp:50: Didn't we add something just like this in ...
4 years, 11 months ago (2016-01-13 20:17:07 UTC) #4
bsalomon
lgtm, but not sure this really gets us closer to hiding GrDT since the callers ...
4 years, 11 months ago (2016-01-13 20:23:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579223003/1
4 years, 11 months ago (2016-01-13 21:17:54 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 21:35:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a8b849911d093c35e10b704c29e73f493d2bf7c4

Powered by Google App Engine
This is Rietveld 408576698