Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1579223002: Fixes #408 (Closed)

Created:
4 years, 11 months ago by vsm
Modified:
4 years, 11 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes #408 This is a bug on JSON.decode. This should match the hand fix in #404. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/12306bf4d511c3c07511d101b2dfbabc244a47c1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M lib/runtime/dart/convert.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 chunk +2 lines, -2 lines 1 comment Download
M test/codegen/expect/collection/wrappers.txt View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/patch/convert_patch.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
https://codereview.chromium.org/1579223002/diff/1/test/codegen/expect/collection/src/unmodifiable_wrappers.txt File test/codegen/expect/collection/src/unmodifiable_wrappers.txt (left): https://codereview.chromium.org/1579223002/diff/1/test/codegen/expect/collection/src/unmodifiable_wrappers.txt#oldcode2 test/codegen/expect/collection/src/unmodifiable_wrappers.txt:2: severe: [AnalyzerMessage] Missing concrete implementation of 'Iterable.map' and 'Iterable.expand' ...
4 years, 11 months ago (2016-01-12 19:13:40 UTC) #3
Jennifer Messerly
LGTM!
4 years, 11 months ago (2016-01-12 20:31:32 UTC) #4
vsm
4 years, 11 months ago (2016-01-12 22:17:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
12306bf4d511c3c07511d101b2dfbabc244a47c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698