net_watcher does not build in Ubuntu 13.04

net/net.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
 
     'linux_link_kerberos%': 0,
     'use_tracing_cache_backend%': 0,
@@ skipping 2446 matching lines @@
             '../base/base.gyp:base',
             'net',
             'net_with_v8',
           ],
           'conditions': [
             [ 'use_glib == 1', {
                 'dependencies': [
                   '../build/linux/system.gyp:gconf',
                   '../build/linux/system.gyp:gio',
                 ],
+                'cflags': [
+                  '-Wno-deprecated-declarations',

[jar (doing other things), 2013/05/31 18:41:30]

How about bracketing the offending lines with:


#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
    g_type_init();
#pragma GCC diagnostic pop

That, plus a comment, would make it clearer why we have this, and give us a good
chance of getting rid of the code some day.

It would also allow other deprecations to be illuminated (if they appear).

WDYT?  Would that work?

+                ]
               },
             ],
           ],
           'sources': [
             'tools/net_watcher/net_watcher.cc',
           ],
         },
         {
           'target_name': 'run_testserver',
           'type': 'executable',
@@ skipping 436 matching lines @@
                 '--result', '<@(_outputs)',
                 '--isolate', 'net_unittests.isolate',
               ],
             },
           ],
         },
       ],
     }],
   ],
 }