Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1579133002: [gn] Fix typos in the documentation. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gn] Fix typos in the documentation. BUG= Committed: https://crrev.com/b541f71072bc92cfcf37ed9b136c6af2c85cfdf9 Cr-Commit-Position: refs/heads/master@{#369420}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/gn/docs/quick_start.md View 1 2 chunks +5 lines, -5 lines 2 comments Download

Messages

Total messages: 14 (4 generated)
Michael Achenbach
PTAL
4 years, 11 months ago (2016-01-12 09:38:28 UTC) #2
Nico
lgtm https://codereview.chromium.org/1579133002/diff/1/tools/gn/docs/quick_start.md File tools/gn/docs/quick_start.md (right): https://codereview.chromium.org/1579133002/diff/1/tools/gn/docs/quick_start.md#newcode269 tools/gn/docs/quick_start.md:269: targets that transitively depend on the current one. ...
4 years, 11 months ago (2016-01-12 15:19:24 UTC) #3
Michael Achenbach
https://codereview.chromium.org/1579133002/diff/1/tools/gn/docs/quick_start.md File tools/gn/docs/quick_start.md (right): https://codereview.chromium.org/1579133002/diff/1/tools/gn/docs/quick_start.md#newcode269 tools/gn/docs/quick_start.md:269: targets that transitively depend on the current one. Now ...
4 years, 11 months ago (2016-01-14 15:09:32 UTC) #4
tfarina
lgtm
4 years, 11 months ago (2016-01-14 15:12:24 UTC) #6
Nico
lgtm
4 years, 11 months ago (2016-01-14 15:14:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579133002/20001
4 years, 11 months ago (2016-01-14 15:26:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 15:43:17 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b541f71072bc92cfcf37ed9b136c6af2c85cfdf9 Cr-Commit-Position: refs/heads/master@{#369420}
4 years, 11 months ago (2016-01-14 15:44:15 UTC) #12
brettw
lgtm https://codereview.chromium.org/1579133002/diff/20001/tools/gn/docs/quick_start.md File tools/gn/docs/quick_start.md (right): https://codereview.chromium.org/1579133002/diff/20001/tools/gn/docs/quick_start.md#newcode326 tools/gn/docs/quick_start.md:326: see the which line caused that config to ...
4 years, 11 months ago (2016-01-19 23:59:46 UTC) #13
Michael Achenbach
4 years, 11 months ago (2016-01-20 07:50:10 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/1579133002/diff/20001/tools/gn/docs/quick_sta...
File tools/gn/docs/quick_start.md (right):

https://codereview.chromium.org/1579133002/diff/20001/tools/gn/docs/quick_sta...
tools/gn/docs/quick_start.md:326: see the which line caused that config to be
applied to your target (in
On 2016/01/19 23:59:46, brettw wrote:
> "see the which line"? Looks like we still have some work to do here :)

Doh. The human brain is a weird thing. I probably concentrated too hard on
fixing one bug, so I missed the obvious other :)

Powered by Google App Engine
This is Rietveld 408576698