chrome/browser/safe_browsing/protocol_manager_unittest.cc - Issue 1579083002: Add UMA metric for GetHash parsing errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_manager_unittest.cc

Issue 1579083002: Add UMA metric for GetHash parsing errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@osb-pm-2

Patch Set: Review Comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/protocol_manager_unittest.cc

diff --git a/chrome/browser/safe_browsing/protocol_manager_unittest.cc b/chrome/browser/safe_browsing/protocol_manager_unittest.cc

index b670f51a672c9d6f57a1924ec84f5ebf5cccb416..fd5e35bcaa5080f1507e6d018dda08428e494ec0 100644

--- a/chrome/browser/safe_browsing/protocol_manager_unittest.cc

+++ b/chrome/browser/safe_browsing/protocol_manager_unittest.cc

@@ -453,7 +453,7 @@ TEST_F(SafeBrowsingProtocolManagerTest,

EXPECT_EQ(0ul, full_hashes.size());

}

-// Adds an entry with an SOCIAL_ENGINEERING threat type.

+// Adds an entry with a SOCIAL_ENGINEERING threat type.

TEST_F(SafeBrowsingProtocolManagerTest,

TestParseV4HashResponseSocialEngineeringThreatType) {

scoped_ptr<SafeBrowsingProtocolManager> pm(CreateProtocolManager(NULL));