Add UMA metric for GetHash parsing errors.

chrome/browser/safe_browsing/protocol_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_PROTOCOL_MANAGER_H_
 #define CHROME_BROWSER_SAFE_BROWSING_PROTOCOL_MANAGER_H_
 
 // A class that implements Chrome's interface with the SafeBrowsing protocol.
 // See https://developers.google.com/safe-browsing/developers_guide_v2 for
 // protocol details.
@@ skipping 161 matching lines @@
   };
 
   // Record a GetHash result. |is_download| indicates if the get
   // hash is triggered by download related lookup.
   static void RecordGetHashResult(bool is_download,
                                   ResultType result_type);
 
   // Record a V4 GetHash result.
   static void RecordGetV4HashResult(ResultType result_type);
 
+  // Enumerate V4 parsing failures for histogramming purposes.  DO NOT CHANGE

[Nathan Parker, 2016/01/15 19:34:43]

This could all go in a n anonymous namespace in the .cc file, since noone
outside of that needs access to it.

[kcarattini, 2016/01/20 04:02:05]

Done.

+  // THE ORDERING OF THESE VALUES.
+  enum ParseResultType {
+    // Error parsing the protocol buffer from a string.
+    PARSE_FROM_STRING_ERROR,

[Nathan Parker, 2016/01/15 19:34:42]

I like to add "= 1.." to each so that you can more easily verify they match the
.xml, and it protects a bit more from accidental reordering.

[kcarattini, 2016/01/20 04:02:05]

Done.

+
+    // A match in the response had an unexpected THREAT_ENTRY_TYPE.
+    UNEXPECTED_THREAT_ENTRY_TYPE_ERROR,
+
+    // A match in the response had an unexpected THREAT_TYPE.
+    UNEXPECTED_THREAT_TYPE_ERROR,
+
+    // A match in the response had an unexpected PLATFORM_TYPE.
+    UNEXPECTED_PLATFORM_TYPE_ERROR,
+
+    // A match in teh response contained no metadata where metadata was
+    // expected.
+    NO_METADATA_ERROR,
+
+    // Memory space for histograms is determined by the max.  ALWAYS
+    // ADD NEW VALUES BEFORE THIS ONE.
+    PARSE_GET_HASH_RESULT_MAX
+  };
+
+  // Record parsing errors of a GetHash result.
+  static void RecordParseGetHashResult(ParseResultType result_type);
+
   // Record HTTP response code when there's no error in fetching an HTTP
   // request, and the error code, when there is.
   // |metric_name| is the name of the UMA metric to record the response code or
   // error code against, |status| represents the status of the HTTP request, and
   // |response code| represents the HTTP response code received from the server.
   static void RecordHttpResponseOrErrorCode(
       const char* metric_name, const net::URLRequestStatus& status,
       int response_code);
 
   // Returns whether another update is currently scheduled.
@@ skipping 325 matching lines @@
       AddChunksCallback callback) = 0;
 
   // Delete chunks from the database.
   virtual void DeleteChunks(
       scoped_ptr<std::vector<SBChunkDelete> > chunk_deletes) = 0;
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_PROTOCOL_MANAGER_H_