Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 15790007: Fix webkitpy unittests. (Closed)

Created:
7 years, 7 months ago by ojan
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Fix webkitpy unittests. -Fix all the things that change now that content shell is the default driver. -Have the default value for --ignore-flaky-tests be None instead of 'default'. Having it be 'default' doesn't gain anything and would require updating a bunch of unittests to set the ignore_flaky_tests to 'default' in their options. TBR=dpranke@chromium.org,jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
Committed patchset #1 manually as r151014 (presubmit successful).
7 years, 7 months ago (2013-05-23 20:41:08 UTC) #1
Dirk Pranke
7 years, 7 months ago (2013-05-23 23:36:15 UTC) #2
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698