Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: net/quic/crypto/proof_verifier_chromium.cc

Issue 1578993003: Add Expect CT policy that gets checked on all certs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rsleevi nits Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/proof_verifier_chromium.cc
diff --git a/net/quic/crypto/proof_verifier_chromium.cc b/net/quic/crypto/proof_verifier_chromium.cc
index 9e3b2ec2ca6c246028440ae7177de71bab0c76f7..2331a6dbf6fbb2f04052d3fc2700e16cf5087e97 100644
--- a/net/quic/crypto/proof_verifier_chromium.cc
+++ b/net/quic/crypto/proof_verifier_chromium.cc
@@ -289,25 +289,31 @@ int ProofVerifierChromium::Job::DoVerifyCertComplete(int result) {
(result == OK && policy_enforcer_ != nullptr);
verify_details_->ct_verify_result.ev_policy_compliance =
ct::EVPolicyCompliance::EV_POLICY_DOES_NOT_APPLY;
- if (result == OK && policy_enforcer_ &&
- (cert_verify_result.cert_status & CERT_STATUS_IS_EV)) {
- ct::EVPolicyCompliance ev_policy_compliance =
- policy_enforcer_->DoesConformToCTEVPolicy(
+ if (result == OK && policy_enforcer_) {
+ if ((cert_verify_result.cert_status & CERT_STATUS_IS_EV)) {
+ ct::EVPolicyCompliance ev_policy_compliance =
+ policy_enforcer_->DoesConformToCTEVPolicy(
+ cert_verify_result.verified_cert.get(),
+ SSLConfigService::GetEVCertsWhitelist().get(),
+ verify_details_->ct_verify_result.verified_scts, net_log_);
+ verify_details_->ct_verify_result.ev_policy_compliance =
+ ev_policy_compliance;
+ if (ev_policy_compliance !=
+ ct::EVPolicyCompliance::EV_POLICY_DOES_NOT_APPLY &&
+ ev_policy_compliance !=
+ ct::EVPolicyCompliance::EV_POLICY_COMPLIES_VIA_WHITELIST &&
+ ev_policy_compliance !=
+ ct::EVPolicyCompliance::EV_POLICY_COMPLIES_VIA_SCTS) {
+ verify_details_->cert_verify_result.cert_status |=
+ CERT_STATUS_CT_COMPLIANCE_FAILED;
+ verify_details_->cert_verify_result.cert_status &= ~CERT_STATUS_IS_EV;
+ }
+ }
+
+ verify_details_->ct_verify_result.cert_policy_compliance =
+ policy_enforcer_->DoesConformToCertPolicy(
cert_verify_result.verified_cert.get(),
- SSLConfigService::GetEVCertsWhitelist().get(),
verify_details_->ct_verify_result.verified_scts, net_log_);
- verify_details_->ct_verify_result.ev_policy_compliance =
- ev_policy_compliance;
- if (ev_policy_compliance !=
- ct::EVPolicyCompliance::EV_POLICY_DOES_NOT_APPLY &&
- ev_policy_compliance !=
- ct::EVPolicyCompliance::EV_POLICY_COMPLIES_VIA_WHITELIST &&
- ev_policy_compliance !=
- ct::EVPolicyCompliance::EV_POLICY_COMPLIES_VIA_SCTS) {
- verify_details_->cert_verify_result.cert_status |=
- CERT_STATUS_CT_COMPLIANCE_FAILED;
- verify_details_->cert_verify_result.cert_status &= ~CERT_STATUS_IS_EV;
- }
}
// TODO(estark): replace 0 below with the port of the connection.

Powered by Google App Engine
This is Rietveld 408576698