Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 1578993003: Add Expect CT policy that gets checked on all certs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rsleevi comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cert/ct_policy_enforcer.h » ('j') | net/cert/ct_policy_enforcer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_browser_tests.cc
diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc
index 20b8c8bc291a94138751fc5f349f74fb62a2ad28..de9263620382bba1e49cde22eb7040fe3da67517 100644
--- a/chrome/browser/ssl/ssl_browser_tests.cc
+++ b/chrome/browser/ssl/ssl_browser_tests.cc
@@ -2505,6 +2505,14 @@ IN_PROC_BROWSER_TEST_F(SSLUITest,
entry = tab->GetController().GetActiveEntry();
ASSERT_TRUE(entry);
+ // Certificate Transparency compliance is not checked until the
+ // connection completes successfully, so the certificate will not have
+ // been marked as failing CT on the interstitial.
+ EXPECT_EQ(0u, interstitial_ssl_status.cert_status &
+ net::CERT_STATUS_CT_COMPLIANCE_FAILED);
+ interstitial_ssl_status.cert_status = interstitial_ssl_status.cert_status |
+ net::CERT_STATUS_CT_COMPLIANCE_FAILED;
+
content::SSLStatus after_interstitial_ssl_status = entry->GetSSL();
ASSERT_NO_FATAL_FAILURE(CheckSSLStatusesEquals(after_interstitial_ssl_status,
interstitial_ssl_status));
@@ -2554,6 +2562,14 @@ IN_PROC_BROWSER_TEST_F(SSLUITest,
// on the clock interstitial.
entry = tab->GetController().GetActiveEntry();
ASSERT_TRUE(entry);
+ // Certificate Transparency compliance is not checked until the
+ // connection completes successfully, so the certificate will not have
+ // been marked as failing CT on the interstitial.
+ EXPECT_EQ(0u, clock_interstitial_ssl_status.cert_status &
+ net::CERT_STATUS_CT_COMPLIANCE_FAILED);
+ clock_interstitial_ssl_status.cert_status =
+ clock_interstitial_ssl_status.cert_status |
+ net::CERT_STATUS_CT_COMPLIANCE_FAILED;
content::SSLStatus after_interstitial_ssl_status = entry->GetSSL();
ASSERT_NO_FATAL_FAILURE(CheckSSLStatusesEquals(
after_interstitial_ssl_status, clock_interstitial_ssl_status));
« no previous file with comments | « no previous file | net/cert/ct_policy_enforcer.h » ('j') | net/cert/ct_policy_enforcer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698