Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1578983002: Optimize SkTileImageFilter in an offset filter when possible. (Closed)

Created:
4 years, 11 months ago by Stephen White
Modified:
4 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Optimize SkTileImageFilter in an offset filter when possible. If the srcRect and dstRect have the same size, tiling will have the same effect as an offset filter cropped to the intersection of srcRect and dstRect. So do that instead. BUG=569950 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1578983002 Committed: https://skia.googlesource.com/skia/+/05dcb4c7a9fe350af495e4cc53f8ad0cc9b79052

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/effects/SkTileImageFilter.cpp View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Stephen White
Rob: PTAL. Thanks!
4 years, 11 months ago (2016-01-11 22:13:59 UTC) #4
robertphillips
lgtm. Do we already have a GM for this case? If not, can you add ...
4 years, 11 months ago (2016-01-12 14:18:29 UTC) #5
Stephen White
> Do we already have a GM for this case? tileimagefilter (the first sample) covers ...
4 years, 11 months ago (2016-01-12 14:23:12 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578983002/20001
4 years, 11 months ago (2016-01-12 14:23:39 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-12 14:33:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578983002/20001
4 years, 11 months ago (2016-01-12 15:48:41 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 15:49:18 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/05dcb4c7a9fe350af495e4cc53f8ad0cc9b79052

Powered by Google App Engine
This is Rietveld 408576698