Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: content/browser/media/webrtc_media_recorder_browsertest.cc

Issue 1578973002: MediaRecorder: fire onError if the amount of tracks of the MediaStream varies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: peter@ comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/data/media/mediarecorder_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/webrtc_media_recorder_browsertest.cc
diff --git a/content/browser/media/webrtc_media_recorder_browsertest.cc b/content/browser/media/webrtc_media_recorder_browsertest.cc
index 381f228da21e5b53615fd4a55be530f2064573db..00f8454dee22bf4df467ec6abcd824eea2f7ecdb 100644
--- a/content/browser/media/webrtc_media_recorder_browsertest.cc
+++ b/content/browser/media/webrtc_media_recorder_browsertest.cc
@@ -76,8 +76,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest, MediaRecorderResume) {
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderNoResumeWhenRecorderInactive) {
- MakeTypicalCall("testIllegalResumeThrowsDOMError();",
- kMediaRecorderHtmlFile);
+ MakeTypicalCall("testIllegalResumeThrowsDOMError();", kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
@@ -98,7 +97,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderPausePreventsDataavailableFromBeingFired) {
MakeTypicalCall("testPausePreventsDataavailableFromBeingFired();",
- kMediaRecorderHtmlFile);
+ kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
@@ -113,26 +112,25 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderIllegalStopThrowsDOMError) {
- MakeTypicalCall("testIllegalStopThrowsDOMError();",
- kMediaRecorderHtmlFile);
+ MakeTypicalCall("testIllegalStopThrowsDOMError();", kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderIllegalStartWhileRecordingThrowsDOMError) {
MakeTypicalCall("testIllegalStartInRecordingStateThrowsDOMError();",
- kMediaRecorderHtmlFile);
+ kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderIllegalStartWhilePausedThrowsDOMError) {
MakeTypicalCall("testIllegalStartInPausedStateThrowsDOMError();",
- kMediaRecorderHtmlFile);
+ kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MediaRecorderIllegalRequestDataThrowsDOMError) {
MakeTypicalCall("testIllegalRequestDataThrowsDOMError();",
- kMediaRecorderHtmlFile);
+ kMediaRecorderHtmlFile);
}
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
@@ -140,4 +138,16 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MakeTypicalCall("testRecordRemotePeerConnection();", kMediaRecorderHtmlFile);
}
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
+ AddingTrackToMediaStreamFiresErrorEvent) {
+ MakeTypicalCall("testAddingTrackToMediaStreamFiresErrorEvent();",
+ kMediaRecorderHtmlFile);
+}
+
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
+ RemovingTrackFromMediaStreamFiresErrorEvent) {
+ MakeTypicalCall("testRemovingTrackFromMediaStreamFiresErrorEvent();",
+ kMediaRecorderHtmlFile);
+}
+
} // namespace content
« no previous file with comments | « no previous file | content/test/data/media/mediarecorder_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698