Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1578963003: Enforce asm restrictions on switch more precisely. (Closed)

Created:
4 years, 11 months ago by bradnelson
Modified:
4 years, 11 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enforce asm restrictions on switch more precisely. Enforce cases have no duplicates. Enforce cases have a maximum range of 2^31. Enforce default case comes last. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/b369fefc80cbf41658b85abf657cf73c07f59141 Cr-Commit-Position: refs/heads/master@{#33221}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M src/typing-asm.cc View 1 3 chunks +21 lines, -3 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bradnelson
4 years, 11 months ago (2016-01-11 23:04:49 UTC) #1
aseemgarg
lgtm
4 years, 11 months ago (2016-01-12 00:48:56 UTC) #2
bradn
switch to ZoneSet, ptal.
4 years, 11 months ago (2016-01-12 01:43:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578963003/20001
4 years, 11 months ago (2016-01-12 01:44:56 UTC) #7
aseemgarg
lgtm
4 years, 11 months ago (2016-01-12 01:53:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-12 02:09:39 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 02:11:29 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b369fefc80cbf41658b85abf657cf73c07f59141
Cr-Commit-Position: refs/heads/master@{#33221}

Powered by Google App Engine
This is Rietveld 408576698