Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 1578963002: dart2js cps: Hoist unsafe expressions from loop entry. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Hoist unsafe expressions from loop entry. Primitives that potentially throw cannot normally be hoisted, but we can sometimes hoist them anyway if they are at the loop entry. We now hoist GetLength, GetField, GetIndex, NullCheck, and BoundsCheck. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/c85916dedc773135bdb4bb4a79112b2ab1a18b52

Patch Set 1 #

Patch Set 2 : Update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M pkg/compiler/lib/src/cps_ir/gvn.dart View 3 chunks +44 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/codeUnitAt_2.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years, 11 months ago (2016-01-11 21:57:02 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 11 months ago (2016-01-11 21:59:29 UTC) #3
asgerf
4 years, 11 months ago (2016-01-12 23:18:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c85916dedc773135bdb4bb4a79112b2ab1a18b52 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698