Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1578943002: Fix GAE <-> GAE RemoteAPI (Closed)

Created:
4 years, 11 months ago by iannucci
Modified:
4 years, 11 months ago
Reviewers:
dnj, Vadim Sh., estaab, martiniss
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M impl/prod/context.go View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (2 generated)
iannucci
4 years, 11 months ago (2016-01-11 21:25:37 UTC) #1
Vadim Sh.
https://chromiumcodereview.appspot.com/1578943002/diff/1/impl/prod/context.go File impl/prod/context.go (right): https://chromiumcodereview.appspot.com/1578943002/diff/1/impl/prod/context.go#newcode117 impl/prod/context.go:117: transp = urlfetch.Get(*inOutCtx) or you can use real URL ...
4 years, 11 months ago (2016-01-11 21:27:18 UTC) #2
dnj
lgtm
4 years, 11 months ago (2016-01-11 21:27:38 UTC) #3
iannucci
On 2016/01/11 at 21:27:18, vadimsh wrote: > https://chromiumcodereview.appspot.com/1578943002/diff/1/impl/prod/context.go > File impl/prod/context.go (right): > > https://chromiumcodereview.appspot.com/1578943002/diff/1/impl/prod/context.go#newcode117 ...
4 years, 11 months ago (2016-01-11 21:30:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578943002/1
4 years, 11 months ago (2016-01-11 21:31:03 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 21:33:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/f91ca7aa49bf83e35ea171cc92ff2183e31d262d

Powered by Google App Engine
This is Rietveld 408576698