src/js/promise.js - Issue 1578893002: Partial rollback of Promise error checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/promise.js

Issue 1578893002: Partial rollback of Promise error checking (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add failing ignition test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/promise.js

diff --git a/src/js/promise.js b/src/js/promise.js

index 48ed821373063185c2c288881bb3296a22facfcc..98a3f409cf1bd3f69daa5fa07ad40ef7d632b94f 100644

--- a/src/js/promise.js

+++ b/src/js/promise.js

@@ -237,11 +237,6 @@ function NewPromiseCapability(C) {

result.reject = reject;

});

- if (!IS_CALLABLE(result.resolve))

- throw MakeTypeError(kCalledNonCallable, "promiseCapability.[[Resolve]]");

- if (!IS_CALLABLE(result.reject))

- throw MakeTypeError(kCalledNonCallable, "promiseCapability.[[Reject]]");

return result;

}

« no previous file with comments | « no previous file | test/mjsunit/mjsunit.status » ('j') | no next file with comments »