Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1578863004: fixes #24711, allow factory constructors to be downcast (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #24711, allow factory constructors to be downcast R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/3aa98fa33545f0f90f286a01594f3c7fde1ee74d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M pkg/analyzer/lib/src/task/strong/info.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
Easy one :)
4 years, 11 months ago (2016-01-11 23:37:17 UTC) #2
Leaf
lgtm
4 years, 11 months ago (2016-01-13 01:06:53 UTC) #3
Jennifer Messerly
4 years, 11 months ago (2016-01-13 17:04:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3aa98fa33545f0f90f286a01594f3c7fde1ee74d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698