[Android] Convert uses of cmd_helper in tools/ to devil.

[Android] Convert uses of cmd_helper in tools/ to devil.

BUG=476719
Committed: https://crrev.com/6f477dbc6d58b9a7e03bf4883c02bbe8f7dc1237
Cr-Commit-Position: refs/heads/master@{#368675}

[jbudorick, 2016-01-11 19:49:20]

jbudorick@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-01-11 19:51:12]

lgtm, but any chance this refactoring can have a non-ridiculous name? Name it
after what it does, and give it a boring and predictable name.

https://codereview.chromium.org/1578863002/diff/1/build/android/pylib/cmd_hel...
File build/android/pylib/cmd_helper.py (left):

https://codereview.chromium.org/1578863002/diff/1/build/android/pylib/cmd_hel...
build/android/pylib/cmd_helper.py:8: from devil.utils.cmd_helper import *
"build/android/pylib" seems like a much better module name than "devil...."

[jbudorick, 2016-01-11 19:57:43]

On 2016/01/11 19:51:12, Nico wrote:
> lgtm, but any chance this refactoring can have a non-ridiculous name? Name it
> after what it does, and give it a boring and predictable name.

:(

I chose devil because it's shorter than "device interaction library", which is
what it does.

> 
>
https://codereview.chromium.org/1578863002/diff/1/build/android/pylib/cmd_hel...
> File build/android/pylib/cmd_helper.py (left):
> 
>
https://codereview.chromium.org/1578863002/diff/1/build/android/pylib/cmd_hel...
> build/android/pylib/cmd_helper.py:8: from devil.utils.cmd_helper import *
> "build/android/pylib" seems like a much better module name than "devil...."

"pylib", the previous root module name, wasn't particularly expressive.
(build/android/ was part of the path but not part of the module name.)

[jbudorick, 2016-01-11 20:18:21]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-01-11 20:19:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1578863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1578863002/1

[Nico, 2016-01-11 20:32:24]

On 2016/01/11 19:57:43, jbudorick wrote:
> On 2016/01/11 19:51:12, Nico wrote:
> > lgtm, but any chance this refactoring can have a non-ridiculous name? Name
it
> > after what it does, and give it a boring and predictable name.
> 
> :(
> 
> I chose devil because it's shorter than "device interaction library", which is
> what it does.

"android.remote" maybe?

> 
> > 
> >
>
https://codereview.chromium.org/1578863002/diff/1/build/android/pylib/cmd_hel...
> > File build/android/pylib/cmd_helper.py (left):
> > 
> >
>
https://codereview.chromium.org/1578863002/diff/1/build/android/pylib/cmd_hel...
> > build/android/pylib/cmd_helper.py:8: from devil.utils.cmd_helper import *
> > "build/android/pylib" seems like a much better module name than "devil...."
> 
> "pylib", the previous root module name, wasn't particularly expressive.
> (build/android/ was part of the path but not part of the module name.)

[jbudorick, 2016-01-11 21:24:37]

On 2016/01/11 20:32:24, Nico wrote:
> On 2016/01/11 19:57:43, jbudorick wrote:
> > On 2016/01/11 19:51:12, Nico wrote:
> > > lgtm, but any chance this refactoring can have a non-ridiculous name? Name
> it
> > > after what it does, and give it a boring and predictable name.
> > 
> > :(
> > 
> > I chose devil because it's shorter than "device interaction library", which
is
> > what it does.

tbh, I'm not really looking to change the name at the moment. I guess I can
understand where you're coming from, but you are the first person to raise such
a concern, and the cost of switching -- especially while this is blocking
telemetry -- is nontrivial.

> 
> "android.remote" maybe?

I get the "android" part, but why remote?

> 
> > 
> > > 
> > >
> >
>
https://codereview.chromium.org/1578863002/diff/1/build/android/pylib/cmd_hel...
> > > File build/android/pylib/cmd_helper.py (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/1578863002/diff/1/build/android/pylib/cmd_hel...
> > > build/android/pylib/cmd_helper.py:8: from devil.utils.cmd_helper import *
> > > "build/android/pylib" seems like a much better module name than
"devil...."
> > 
> > "pylib", the previous root module name, wasn't particularly expressive.
> > (build/android/ was part of the path but not part of the module name.)

[Nico, 2016-01-11 21:26:06]

On 2016/01/11 21:24:37, jbudorick wrote:
> On 2016/01/11 20:32:24, Nico wrote:
> > On 2016/01/11 19:57:43, jbudorick wrote:
> > > On 2016/01/11 19:51:12, Nico wrote:
> > > > lgtm, but any chance this refactoring can have a non-ridiculous name?
Name
> > it
> > > > after what it does, and give it a boring and predictable name.
> > > 
> > > :(
> > > 
> > > I chose devil because it's shorter than "device interaction library",
which
> is
> > > what it does.
> 
> tbh, I'm not really looking to change the name at the moment. I guess I can
> understand where you're coming from, but you are the first person to raise
such
> a concern, and the cost of switching -- especially while this is blocking
> telemetry -- is nontrivial.

I'm guessing you haven't asked many people what they'd guess a library called
"devil" would do. I guarantee that 0% of people who don't already know what it
does will guess correctly.

> 
> > 
> > "android.remote" maybe?
> 
> I get the "android" part, but why remote?

Since it controls a remote device? But any descriptive name is fine, really.

[jbudorick, 2016-01-11 21:28:23]

On 2016/01/11 21:26:06, Nico wrote:
> On 2016/01/11 21:24:37, jbudorick wrote:
> > On 2016/01/11 20:32:24, Nico wrote:
> > > On 2016/01/11 19:57:43, jbudorick wrote:
> > > > On 2016/01/11 19:51:12, Nico wrote:
> > > > > lgtm, but any chance this refactoring can have a non-ridiculous name?
> Name
> > > it
> > > > > after what it does, and give it a boring and predictable name.
> > > > 
> > > > :(
> > > > 
> > > > I chose devil because it's shorter than "device interaction library",
> which
> > is
> > > > what it does.
> > 
> > tbh, I'm not really looking to change the name at the moment. I guess I can
> > understand where you're coming from, but you are the first person to raise
> such
> > a concern, and the cost of switching -- especially while this is blocking
> > telemetry -- is nontrivial.
> 
> I'm guessing you haven't asked many people what they'd guess a library called
> "devil" would do. I guarantee that 0% of people who don't already know what it
> does will guess correctly.

True. It's hardly unique in that regard, not that that's much of a defense.

> 
> > 
> > > 
> > > "android.remote" maybe?
> > 
> > I get the "android" part, but why remote?
> 
> Since it controls a remote device? But any descriptive name is fine, really.

[commit-bot: I haz the power, 2016-01-11 21:40:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-11 21:42:16]

Description was changed from

==========
[Android] Convert uses of cmd_helper in tools/ to devil.

BUG=476719
==========

to

==========
[Android] Convert uses of cmd_helper in tools/ to devil.

BUG=476719

Committed: https://crrev.com/6f477dbc6d58b9a7e03bf4883c02bbe8f7dc1237
Cr-Commit-Position: refs/heads/master@{#368675}
==========

[commit-bot: I haz the power, 2016-01-11 21:42:16]

Patchset 1 (id:??) landed as
https://crrev.com/6f477dbc6d58b9a7e03bf4883c02bbe8f7dc1237
Cr-Commit-Position: refs/heads/master@{#368675}