Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1578843002: Add missing destructor to ChromeWatcherCommandLineGenerator. (Closed)

Created:
4 years, 11 months ago by chrisha
Modified:
4 years, 11 months ago
Reviewers:
Nico, grt (UTC plus 2)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing destructor to ChromeWatcherCommandLineGenerator. This was initially missed in https://codereview.chromium.org/1538923004/ BUG=576299 TBR=grt@chromium.org,thakis@chromium.org Committed: https://crrev.com/8106a6b9b4ea73542e406a9e66b48df8c1613437 Cr-Commit-Position: refs/heads/master@{#368669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/app/chrome_watcher_command_line_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_watcher_command_line_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
chrisha
thakis: PTAL?
4 years, 11 months ago (2016-01-11 19:38:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578843002/1
4 years, 11 months ago (2016-01-11 19:38:44 UTC) #6
Nico
rs-lgtm, thanks
4 years, 11 months ago (2016-01-11 19:42:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 21:18:06 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 21:18:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8106a6b9b4ea73542e406a9e66b48df8c1613437
Cr-Commit-Position: refs/heads/master@{#368669}

Powered by Google App Engine
This is Rietveld 408576698