src/compiler/bytecode-graph-builder.cc - Issue 1578723002: [turbofan] Build s/NULL/nullptr/g and CHECK(x != nullptr) to CHECK_NOT_NULL(x).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 1578723002: [turbofan] Build s/NULL/nullptr/g and CHECK(x != nullptr) to CHECK_NOT_NULL(x). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/bytecode-graph-builder.cc

diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc

index a64f1fb509fe39a186044d82a582d5158eaea1dd..d24ae3c56fbb5315249661106707a77988c7069d 100644

--- a/src/compiler/bytecode-graph-builder.cc

+++ b/src/compiler/bytecode-graph-builder.cc

@@ -1875,7 +1875,7 @@ Node* BytecodeGraphBuilder::MakeNode(const Operator* op, int value_input_count,

DCHECK_LT(op->ControlInputCount(), 2);

DCHECK_LT(op->EffectInputCount(), 2);

- Node* result = NULL;

+ Node* result = nullptr;

if (!has_context && frame_state_count == 0 && !has_control && !has_effect) {

result = graph()->NewNode(op, value_input_count, value_inputs, incomplete);

} else {

« no previous file with comments | « src/compiler/bytecode-graph-builder.h ('k') | src/compiler/coalesced-live-ranges.h » ('j') | no next file with comments »