Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: src/compiler/arm/instruction-selector-arm.cc

Issue 1578723002: [turbofan] Build s/NULL/nullptr/g and CHECK(x != nullptr) to CHECK_NOT_NULL(x). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | src/compiler/arm64/code-generator-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/base/bits.h" 6 #include "src/base/bits.h"
7 #include "src/compiler/instruction-selector-impl.h" 7 #include "src/compiler/instruction-selector-impl.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 10
(...skipping 1340 matching lines...) Expand 10 before | Expand all | Expand 10 after
1351 return VisitFloat64Compare(selector, value, cont); 1351 return VisitFloat64Compare(selector, value, cont);
1352 case IrOpcode::kFloat64LessThanOrEqual: 1352 case IrOpcode::kFloat64LessThanOrEqual:
1353 cont->OverwriteAndNegateIfEqual(kFloatLessThanOrEqual); 1353 cont->OverwriteAndNegateIfEqual(kFloatLessThanOrEqual);
1354 return VisitFloat64Compare(selector, value, cont); 1354 return VisitFloat64Compare(selector, value, cont);
1355 case IrOpcode::kProjection: 1355 case IrOpcode::kProjection:
1356 // Check if this is the overflow output projection of an 1356 // Check if this is the overflow output projection of an
1357 // <Operation>WithOverflow node. 1357 // <Operation>WithOverflow node.
1358 if (ProjectionIndexOf(value->op()) == 1u) { 1358 if (ProjectionIndexOf(value->op()) == 1u) {
1359 // We cannot combine the <Operation>WithOverflow with this branch 1359 // We cannot combine the <Operation>WithOverflow with this branch
1360 // unless the 0th projection (the use of the actual value of the 1360 // unless the 0th projection (the use of the actual value of the
1361 // <Operation> is either NULL, which means there's no use of the 1361 // <Operation> is either nullptr, which means there's no use of the
1362 // actual value, or was already defined, which means it is scheduled 1362 // actual value, or was already defined, which means it is scheduled
1363 // *AFTER* this branch). 1363 // *AFTER* this branch).
1364 Node* const node = value->InputAt(0); 1364 Node* const node = value->InputAt(0);
1365 Node* const result = NodeProperties::FindProjection(node, 0); 1365 Node* const result = NodeProperties::FindProjection(node, 0);
1366 if (!result || selector->IsDefined(result)) { 1366 if (!result || selector->IsDefined(result)) {
1367 switch (node->opcode()) { 1367 switch (node->opcode()) {
1368 case IrOpcode::kInt32AddWithOverflow: 1368 case IrOpcode::kInt32AddWithOverflow:
1369 cont->OverwriteAndNegateIfEqual(kOverflow); 1369 cont->OverwriteAndNegateIfEqual(kOverflow);
1370 return VisitBinop(selector, node, kArmAdd, kArmAdd, cont); 1370 return VisitBinop(selector, node, kArmAdd, kArmAdd, cont);
1371 case IrOpcode::kInt32SubWithOverflow: 1371 case IrOpcode::kInt32SubWithOverflow:
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
1601 MachineOperatorBuilder::kFloat64RoundTiesAway | 1601 MachineOperatorBuilder::kFloat64RoundTiesAway |
1602 MachineOperatorBuilder::kFloat32RoundTiesEven | 1602 MachineOperatorBuilder::kFloat32RoundTiesEven |
1603 MachineOperatorBuilder::kFloat64RoundTiesEven; 1603 MachineOperatorBuilder::kFloat64RoundTiesEven;
1604 } 1604 }
1605 return flags; 1605 return flags;
1606 } 1606 }
1607 1607
1608 } // namespace compiler 1608 } // namespace compiler
1609 } // namespace internal 1609 } // namespace internal
1610 } // namespace v8 1610 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | src/compiler/arm64/code-generator-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698