Issue 15786004: Un-flake test-cpu-profiler/SampleWhenFrameIsNotSetup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15786004: Un-flake test-cpu-profiler/SampleWhenFrameIsNotSetup (Closed)

Created:
7 years, 7 months ago by yurys

Modified:
7 years, 7 months ago

Reviewers:
Sven Panne, Jakob Kummerow, alph, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Un-flake test-cpu-profiler/SampleWhenFrameIsNotSetup It is OK for FindChild to return NULL. If the child must exist GetChild should be used to force the assertion. BUG=v8:2628 R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14809

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -10 lines)			Patch
	M	test/cctest/cctest.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	test/cctest/test-cpu-profiler.cc	View		3 chunks	+13 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

yurys

7 years, 7 months ago (2013-05-24 16:19:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14809 (presubmit successful).