Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1578543002: Fix an uninitalized read in FPDFText_GetFontSize(). (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
jun_fang
CC:
pdfium-reviews_googlegroups.com, jbreiden
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : nit #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -50 lines) Patch
M core/include/fpdftext/fpdf_text.h View 3 chunks +5 lines, -3 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 1 2 9 chunks +44 lines, -40 lines 0 comments Download
M core/src/fpdftext/text_int.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 4 chunks +5 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 3 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
4 years, 11 months ago (2016-01-09 03:21:13 UTC) #2
jun_fang
LGTM https://codereview.chromium.org/1578543002/diff/20001/core/src/fpdftext/fpdf_text_int.cpp File core/src/fpdftext/fpdf_text_int.cpp (right): https://codereview.chromium.org/1578543002/diff/20001/core/src/fpdftext/fpdf_text_int.cpp#newcode80 core/src/fpdftext/fpdf_text_int.cpp:80: const FX_FLOAT kDefaultFontSize = 1; nit: Replace 1 ...
4 years, 11 months ago (2016-01-09 08:38:56 UTC) #3
Lei Zhang
https://codereview.chromium.org/1578543002/diff/20001/core/src/fpdftext/fpdf_text_int.cpp File core/src/fpdftext/fpdf_text_int.cpp (right): https://codereview.chromium.org/1578543002/diff/20001/core/src/fpdftext/fpdf_text_int.cpp#newcode80 core/src/fpdftext/fpdf_text_int.cpp:80: const FX_FLOAT kDefaultFontSize = 1; On 2016/01/09 08:38:56, jun_fang ...
4 years, 11 months ago (2016-01-11 19:44:43 UTC) #4
Lei Zhang
4 years, 11 months ago (2016-01-11 19:48:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
401cd2dbaaa10790077de2fd70e8101b0bdd0f36 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698