Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 157853002: Revert of Use removeFontFace to avoid resetting fontSelector. (Closed)

Created:
6 years, 10 months ago by abarth-chromium
Modified:
6 years, 10 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears
Visibility:
Public.

Description

Revert of Use removeFontFace to avoid resetting fontSelector. (https://codereview.chromium.org/82583005/) Reason for revert: This CL appears to have broken org.chromium.android_webview.test.AwSettingsTest#testLayoutAlgorithmWithTwoViews in androidwebview_instrumentation_tests. http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/17264 Original issue's description: > Use removeFontFace to avoid resetting fontSelector. > > BUG=305885, 336756 > TEST=fast/css/font-face-remove.html, fast/css/font-face-html-as-svg.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166681 TBR=ksakamoto@chromium.org,esprehn@chromium.org,ojan@chromium.org,dglazkov@chromium.org,tasak@google.com NOTREECHECKS=true NOTRY=true BUG=305885, 336756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -239 lines) Patch
D LayoutTests/fast/css/cssom-modify-font-face-rule.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/css/cssom-modify-font-face-rule-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/css/font-face-insertBefore.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/css/font-face-insertBefore-expected.html View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/core/css/CSSFontSelector.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/core/css/FontFaceCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/FontFaceCache.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/css/StyleSheetContents.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 4 chunks +3 lines, -47 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/core/dom/StyleEngine.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 2 chunks +19 lines, -29 lines 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.cpp View 2 chunks +27 lines, -14 lines 0 comments Download
M Source/core/frame/Settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/SettingsDelegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 7 chunks +0 lines, -7 lines 0 comments Download
M Source/platform/fonts/FontDescription.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/fonts/GenericFontFamilySettings.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/GenericFontFamilySettings.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
Created Revert of Use removeFontFace to avoid resetting fontSelector.
6 years, 10 months ago (2014-02-07 19:38:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/157853002/1
6 years, 10 months ago (2014-02-07 19:38:53 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 19:39:32 UTC) #3
Message was sent while issue was closed.
Change committed as 166732

Powered by Google App Engine
This is Rietveld 408576698