Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1578523002: Move SelectionBoundType to inside the LayerSelectionBound message. (Closed)

Created:
4 years, 11 months ago by nyquist
Modified:
4 years, 11 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SelectionBoundType to inside the LayerSelectionBound message. The SelectionBoundType is only used inside the LayerSelectionBound proto message, so it should be part of that instead of a top-level proto, which causes issues with other top-level enums in the same namespace. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7500fb48839f028a04c2c2295bc9c53fbe340d7c Cr-Commit-Position: refs/heads/master@{#368781}

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
nyquist
vmpstr: PTAL
4 years, 11 months ago (2016-01-11 20:06:25 UTC) #3
vmpstr
lgtm
4 years, 11 months ago (2016-01-11 21:51:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578523002/1
4 years, 11 months ago (2016-01-12 01:18:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 02:47:17 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 02:49:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7500fb48839f028a04c2c2295bc9c53fbe340d7c
Cr-Commit-Position: refs/heads/master@{#368781}

Powered by Google App Engine
This is Rietveld 408576698