Add $(inherited) to the conditional OTHER_LDFLAGS settings to prevent them from masking

Add $(inherited) to the conditional OTHER_LDFLAGS settings to prevent them from masking
the value of non-conditional OTHER_LDFLAGS.

R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205521

[Alexander Potapenko, 2013-06-11 13:21:48]

Mark can you please check whether this is correct?
In a 32-bit iossim ASan build the flags passed via OTHER_LDFLAGS had been
dropped by xcodebuild because the more specific OTHER_LDFLAGS[arch=i386] were in
place. Adding $(inherited) in front of the conditional flags (as Nico suggested)
seems to help.

[Mark Mentovai, 2013-06-11 13:23:14]

LGTM in that $(inherited) is correct, but we should strive to get rid of the
[arch=] syntax.

[Alexander Potapenko, 2013-06-11 13:23:30]

On 2013/06/11 13:21:48, Alexander Potapenko wrote:
> Mark can you please check whether this is correct?
> In a 32-bit iossim ASan build the flags passed via OTHER_LDFLAGS had been
> dropped by xcodebuild because the more specific OTHER_LDFLAGS[arch=i386] were
in
> place. Adding $(inherited) in front of the conditional flags (as Nico
suggested)
> seems to help.

BTW do we have any xcodebuild trybots?

[Alexander Potapenko, 2013-06-11 13:25:15]

Committed patchset #1 manually as r205521 (presubmit successful).

[Mark Mentovai, 2013-06-11 13:39:52]

I don’t think so.

[Nico, 2013-06-11 17:10:14]

On Tue, Jun 11, 2013 at 6:23 AM, <glider@chromium.org> wrote:

> On 2013/06/11 13:21:48, Alexander Potapenko wrote:
>
>> Mark can you please check whether this is correct?
>> In a 32-bit iossim ASan build the flags passed via OTHER_LDFLAGS had been
>> dropped by xcodebuild because the more specific OTHER_LDFLAGS[arch=i386]
>> were
>>
> in
>
>> place. Adding $(inherited) in front of the conditional flags (as Nico
>>
> suggested)
>
>> seems to help.
>>
>
> BTW do we have any xcodebuild trybots?
>

http://build.chromium.org/p/tryserver.chromium/waterfall lists all trybots.
There's "mac_xcodebuild".


>
>
https://codereview.chromium.**org/15785007/<https://codereview.chromium.org/1...
>