Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: mojo/shell/public/interfaces/shell.mojom

Issue 1578473002: Pass application ids via AcceptConnection & ConnectToApplication callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/public/interfaces/shell.mojom
diff --git a/mojo/shell/public/interfaces/shell.mojom b/mojo/shell/public/interfaces/shell.mojom
index b70b9fe5f7c239762d8568a1fcba38620e54afbe..787ed11b96fdf302a86b556e5402807799e5b02d 100644
--- a/mojo/shell/public/interfaces/shell.mojom
+++ b/mojo/shell/public/interfaces/shell.mojom
@@ -24,8 +24,7 @@ struct CapabilityFilter {
// An interface through which a Mojo application may communicate with the Mojo
// system and request connections to other applications.
interface Shell {
- // Used to indicate the app was not launched by a content handler.
- const uint32 kInvalidContentHandlerID = 0;
+ const uint32 kInvalidApplicationID = 0;
// Establishes a connection with another application ("target application")
// (located at |request->url|) through which the calling application and the
@@ -61,12 +60,12 @@ interface Shell {
// If the connection to |application_url| involves a content handler, then
// |content_handler_id| is the id of the deepest content handler used to
// establish the connection to |application_url|. If no content handler is
- // used |content_handler_id| is kInvalidContentHandlerID.
- // TODO(beng): determine if we need to expose the target application id also.
+ // used |content_handler_id| is kInvalidApplicationID.
ConnectToApplication(URLRequest application_url,
ServiceProvider&? services,
ServiceProvider? exposed_services,
- CapabilityFilter filter) => (uint32 content_handler_id);
+ CapabilityFilter filter) =>
+ (uint32 application_id, uint32 content_handler_id);
// When there are no more instantiated services in an application, it should
// start its shutdown process by calling this method. Additionally, it should

Powered by Google App Engine
This is Rietveld 408576698