mojo/shell/application_manager_apptest_target.cc - Issue 1578473002: Pass application ids via AcceptConnection & ConnectToApplication callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/application_manager_apptest_target.cc

Issue 1578473002: Pass application ids via AcceptConnection & ConnectToApplication callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/shell/application_manager_apptest_driver.cc ('k') | mojo/shell/application_manager_apptests.mojom » ('j') | mojo/shell/public/interfaces/application.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/shell/application_manager_apptest_target.cc

diff --git a/mojo/shell/application_manager_apptest_target.cc b/mojo/shell/application_manager_apptest_target.cc

index 62534fd412735c1f7c5555b24f98e27da561e741..883ed3e489dd0f8df0d91203e88feff726f8059e 100644

--- a/mojo/shell/application_manager_apptest_target.cc

+++ b/mojo/shell/application_manager_apptest_target.cc

@@ -26,7 +26,7 @@ class TargetApplicationDelegate : public mojo::ApplicationDelegate {

void Initialize(mojo::ApplicationImpl* app) override {

CreateInstanceForHandleTestPtr service;

app->ConnectToService("mojo:mojo_shell_apptests", &service);

- service->Ping("From Target");

+ service->SetTargetID(app->id());

}

bool ConfigureIncomingConnection(

mojo::ApplicationConnection* connection) override {