components/web_view/frame_utils.cc - Issue 1578473002: Pass application ids via AcceptConnection & ConnectToApplication callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/frame_utils.cc

Issue 1578473002: Pass application ids via AcceptConnection & ConnectToApplication callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_view/frame_connection.cc ('k') | content/browser/mojo/mojo_app_connection_impl.cc » ('j') | mojo/shell/public/interfaces/application.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_view/frame_utils.cc

diff --git a/components/web_view/frame_utils.cc b/components/web_view/frame_utils.cc

index b95e4f953e42558e6a01e7401f9b83fed3bc5ef8..03ee9e23bcb713556b977023149a805887beca62 100644

--- a/components/web_view/frame_utils.cc

+++ b/components/web_view/frame_utils.cc

@@ -20,7 +20,7 @@ bool AlwaysCreateNewFrameTree() {

bool AreAppIdsEqual(uint32_t app_id1, uint32_t app_id2) {

return app_id1 == app_id2 &&

- app_id1 != mojo::Shell::kInvalidContentHandlerID &&

+ app_id1 != mojo::Shell::kInvalidApplicationID &&

!AlwaysCreateNewFrameTree();

}