Added PlatformHandle thunks.

mojo/public/platform/native/platform_handle_private.h

+// Copyright 2015 The Chromium Authors. All rights reserved.

[viettrungluu, 2016/02/18 01:10:07]

2016?

[Forrest Reiling, 2016/02/23 23:48:45]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MOJO_PLATFORM_HANDLE_PLATFORM_HANDLE_FUNCTIONS_H_

[viettrungluu, 2016/02/18 01:10:07]

Update this header guard.

[Forrest Reiling, 2016/02/23 23:48:45]

Done.

+#define MOJO_PLATFORM_HANDLE_PLATFORM_HANDLE_FUNCTIONS_H_
+
+#include "mojo/public/c/system/types.h"
+
+typedef int MojoPlatformHandle;  // Unix file descriptor
+
+#if defined(__cplusplus)

[viettrungluu, 2016/02/18 01:10:07]

I think we conventionally/mostly use #ifdef when checking __cplusplus.

[Forrest Reiling, 2016/02/23 23:48:45]

Wait what? So we use '#if defined()' everywhere except for checking if
__cplusplus is defined? Doesn't that strike you as strange/terrible? Not that
the choice of directive/macro make a bit of difference to me, but the usage
rules seem pretty fuzzy and unclear. are the rules spelled out somewhere?

+extern "C" {
+#endif
+
+// Wraps |platform_handle| in a MojoHandle so that it can transported. Returns
+// MOJO_RESULT_OK on success, all other results indicate failure. This takes
+// ownership of |platform_handle|, regardless of whether this succeeds.
+MojoResult MojoCreatePlatformHandleWrapper(MojoPlatformHandle platform_handle,
+                                           MojoHandle* wrapper);
+
+// Extracts |platform_handle| from |wrapper|. Returns MOJO_RESULT_OK on success,
+// all other results indicate failure. If this succeeds, it causes |wrapper| to
+// relinquish ownership of |platform_handle|, so MojoClose'ing |wrapper| will no
+// longer close the underlying |platform_handle|

[viettrungluu, 2016/02/18 01:10:07]

Probably mention that |wrapper| nonetheless should still be MojoClose()ed.

[Forrest Reiling, 2016/02/23 23:48:45]

Along the lines of my other comment on the matter, is this actually true? If
this succeeds, then the handle no longer owns the wrapped fd, so that fd should
be closed on its own and shouldnt need to be closed though the mojo handle. Does
MojoClose() have other side effects that I'm not aware of? Does it actually do
something useful when called on a MojoHandle that doesnt own an fd?

+MojoResult MojoExtractPlatformHandle(MojoHandle wrapper,
+                                     MojoPlatformHandle* platform_handle);
+
+#if defined(__cplusplus)

[viettrungluu, 2016/02/18 01:10:07]

...

[Forrest Reiling, 2016/02/23 23:48:45]

Done.

+}  // extern "C"
+#endif
+
+#endif  // MOJO_PLATFORM_HANDLE_PLATFORM_HANDLE_FUNCTIONS_H_