Added PlatformHandle thunks.

mojo/public/platform/native/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("../../mojo_sdk.gni")
+import("$mojo_root/mojo/public/mojo_application.gni")

[viettrungluu, 2016/02/18 01:10:06]

Just use a relative path, like the import above?

[Forrest Reiling, 2016/02/23 23:48:44]

Done.

 
 mojo_sdk_source_set("system") {
   sources = [
     "system_thunks.c",
     "system_thunks.h",
   ]
   mojo_sdk_deps = [ "mojo/public/c/system" ]
 
   # The GYP target analogous to this one builds this code into a
   # static library.  When building for Android, both the GYP and GN
@@ skipping 102 matching lines @@
 }
 
 mojo_sdk_source_set("mgl_onscreen_thunks") {
   sources = [
     "mgl_onscreen_thunks.c",
     "mgl_onscreen_thunks.h",
   ]
 
   mojo_sdk_deps = [ "mojo/public/c/gpu:MGL_onscreen" ]
 }
+
+mojo_sdk_source_set("platform_handle") {
+  restrict_external_deps = false
+  sources = [
+    "platform_handle_private_thunks.c",
+    "platform_handle_private_thunks.h",
+  ]
+
+  deps = [
+    ":platform_handle_defs",
+    "$mojo_root/mojo/public/c/system",

[viettrungluu, 2016/02/18 01:10:06]

Use mojo_sdk_deps instead of "$mojo_root".

[Forrest Reiling, 2016/02/23 23:48:44]

Done.

+  ]
+
+  defines = [ "PLATFORM_HANDLE_IMPLEMENTATION" ]

[viettrungluu, 2016/02/18 01:10:06]

Pretty sure you don't need this.

[Forrest Reiling, 2016/02/23 23:48:44]

Done.

+}
+
+# Only targets that are registering the thunks should depend upon this.

[viettrungluu, 2016/02/18 01:10:06]

"registering" is a confusing term.

[Forrest Reiling, 2016/02/23 23:48:44]

going with 'calling the thunks' instead

+mojo_sdk_source_set("platform_handle_defs") {

[viettrungluu, 2016/02/18 01:10:06]

Probably call it "api" instead of "defs", like system_impl_private_api above.

[Forrest Reiling, 2016/02/23 23:48:44]

Done.

+  restrict_external_deps = false
+  sources = [
+    "platform_handle_private.h",
+  ]
+  deps = [

[viettrungluu, 2016/02/18 01:10:06]

mojo_sdk_deps

[Forrest Reiling, 2016/02/23 23:48:44]

Done.

+    "$mojo_root/mojo/public/c/system:system",
+  ]
+}
+
+mojo_native_application("platform_handle_apptest") {

[viettrungluu, 2016/02/18 01:10:06]

Probably have a "tests" group that depends on this (and depend on that from
outside this directory)?

[Forrest Reiling, 2016/02/23 23:48:44]

If I do that do you want me to put the other test targets in this build file in
there? Im not really sure what the dependency chain for the rest of the tests in
here look like, or through what dependency chain this test is supposed to be
built. Right now it is depended on by the //mojo:tests target, but I'm not super
clear on if thats right. Is there documentation on the right way to add tests to
mojo?

[viettrungluu, 2016/02/24 18:09:57]

Probably, if you can.
That seems fine. It'd be good to avoid having to add individual tests to
//mojo/BUILD.gn.
Ha.

[Forrest Reiling, 2016/02/24 20:10:42]

Done.

+  output_name = "platform_handle_apptests"
+
+  testonly = true
+
+  sources = [
+    "platform_handle_apptest.cc",
+  ]
+
+  deps = [
+    ":platform_handle",
+    ":platform_handle_defs",
+    "$mojo_root/mojo/public/cpp/application:standalone",

[viettrungluu, 2016/02/18 01:10:06]

mojo_sdk_deps

[Forrest Reiling, 2016/02/23 23:48:44]

when I do this here it says the variable goes out of scope before it is used.
Are you sure this is appropriate for 'mojo_native_application' target? is there
a different target AI should be using for the app tests? should the apptests not
live here? Again I'm kindof fuzzy on the best way to add mojo tests

[viettrungluu, 2016/02/24 18:09:57]

Blech. Probably mojo_native_application (in //mojo/public/mojo_application.gni
should be made to handle mojo_sdk_deps (see //mojo/public/mojo_sdk.gni).

Or, if you're lazy, you can use a relative path instead, I guess.

[Forrest Reiling, 2016/02/24 20:10:42]

using relative path

+    "$mojo_root/mojo/public/cpp/application:test_support_standalone",
+    "$mojo_root/mojo/public/cpp/environment",
+    "$mojo_root/mojo/public/cpp/system",
+  ]
+}