mojo/platform_handle/platform_handle_functions.h - Issue 1578423002: Added PlatformHandle thunks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/platform_handle/platform_handle_functions.h

Issue 1578423002: Added PlatformHandle thunks. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« mojo/platform_handle/platform_handle_apptest.cc ('K') | « mojo/platform_handle/platform_handle_apptest.cc ('k') | mojo/platform_handle/platform_handle_private_thunks.h » ('j') | mojo/platform_handle/platform_handle_private_thunks.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.
	viettrungluu 2016/02/02 00:07:36 This file should also live under //mojo/public/pla This file should also live under //mojo/public/platform/native. Probably just call it "platform_handle_private.h". Forrest Reiling 2016/02/10 20:16:08 Done. Show quoted text On 2016/02/02 00:07:36, viettrungluu wrote: > This file should also live under //mojo/public/platform/native. > > Probably just call it "platform_handle_private.h". Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MOJO_PLATFORM_HANDLE_PLATFORM_HANDLE_FUNCTIONS_H_

	6 #define MOJO_PLATFORM_HANDLE_PLATFORM_HANDLE_FUNCTIONS_H_

	7

	8 #include "mojo/public/c/system/types.h"

	9

	10 using MojoPlatformHandle = int; // Unix file descriptor
	viettrungluu 2016/02/02 00:07:36 This header should be compilable as C, so you shou This header should be compilable as C, so you should use a typedef. Forrest Reiling 2016/02/10 20:16:08 Done. Show quoted text On 2016/02/02 00:07:36, viettrungluu wrote: > This header should be compilable as C, so you should use a typedef. Done.
	11

	12 extern "C" {
	viettrungluu 2016/02/02 00:07:36 And wrap this line in #ifdef __cplusplus (and ditt And wrap this line in #ifdef __cplusplus (and ditto for the closing brace). Forrest Reiling 2016/02/10 20:16:09 Done. Show quoted text On 2016/02/02 00:07:36, viettrungluu wrote: > And wrap this line in #ifdef __cplusplus (and ditto for the closing brace). Done.
	13

	14 // Wraps \|platform_handle\| in a MojoHandle so that it can transported, returns

	15 // true on success. This takes ownership of \|platform_handle\|, regardless of
	viettrungluu 2016/02/02 00:07:36 It so doesn't return "true". It so doesn't return "true". Forrest Reiling 2016/02/10 20:16:09 Done. Show quoted text On 2016/02/02 00:07:36, viettrungluu wrote: > It so doesn't return "true". Done.
	16 // whether this succeeds.

	17 MojoResult MojoCreatePlatformHandleWrapper(MojoPlatformHandle platform_handle,

	18 MojoHandle* wrapper);

	19

	20 MojoResult MojoExtractPlatformHandle(MojoHandle wrapper,
	viettrungluu 2016/02/02 00:07:36 This could use a comment too. This could use a comment too. Forrest Reiling 2016/02/10 20:16:08 Done. Show quoted text On 2016/02/02 00:07:36, viettrungluu wrote: > This could use a comment too. Done.
	21 MojoPlatformHandle* platform_handle);

	22

	23 } // extern "C"

	24

	25 #endif // MOJO_PLATFORM_HANDLE_PLATFORM_HANDLE_FUNCTIONS_H_

OLD	NEW