Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1578413002: [libfuzzer] unittest-style main driver. (Closed)

Created:
4 years, 11 months ago by aizatsky
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] unittest-style main driver. Use unittest driver in non-fuzzer build. BUG=539572 Committed: https://crrev.com/c562c13d21a7006f973562af6b33bd784a396a71 Cr-Commit-Position: refs/heads/master@{#370228}

Patch Set 1 #

Patch Set 2 : nits #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -9 lines 0 comments Download
M testing/libfuzzer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M testing/libfuzzer/fuzzers/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/libfuzzer/fuzzers/pdfium_fuzzer.cc View 1 chunk +1 line, -0 lines 0 comments Download
A testing/libfuzzer/unittest_main.cc View 1 1 chunk +32 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (5 generated)
aizatsky
Please take a look.
4 years, 11 months ago (2016-01-12 22:16:04 UTC) #3
inferno
lgtm
4 years, 11 months ago (2016-01-12 22:19:58 UTC) #4
mmoroz
LGTM with a small nit https://codereview.chromium.org/1578413002/diff/20001/testing/libfuzzer/unittest_main.cc File testing/libfuzzer/unittest_main.cc (right): https://codereview.chromium.org/1578413002/diff/20001/testing/libfuzzer/unittest_main.cc#newcode30 testing/libfuzzer/unittest_main.cc:30: LLVMFuzzerTestOneInput((const unsigned char *)v.data(), ...
4 years, 11 months ago (2016-01-13 10:16:09 UTC) #5
aizatsky
Derek, Can you please review the root BUILD.gn change?
4 years, 11 months ago (2016-01-13 21:48:56 UTC) #6
aizatsky
Dirk, of course it is Dirk, I'm sorry. Too many windows open.
4 years, 11 months ago (2016-01-13 21:49:44 UTC) #7
Dirk Pranke
lgtm. Sorry for the delay; I've been out a lot.
4 years, 11 months ago (2016-01-19 22:18:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578413002/20001
4 years, 11 months ago (2016-01-19 22:49:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-20 00:00:23 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 00:01:36 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c562c13d21a7006f973562af6b33bd784a396a71
Cr-Commit-Position: refs/heads/master@{#370228}

Powered by Google App Engine
This is Rietveld 408576698