third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp - Issue 1578363009: CacheStorage: Add ignoreSearch option to cache.matchAll().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

Issue 1578363009: CacheStorage: Add ignoreSearch option to cache.matchAll(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/Cache.cpp ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp b/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

index 91b6acf3b5d596757de60b44538a661528804198..dadae076c295fb91174effb9dd0e5885801edebe 100644

--- a/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

@@ -12,6 +12,7 @@

#include "modules/cachestorage/CacheStorageError.h"

#include "modules/fetch/Request.h"

#include "modules/fetch/Response.h"

+#include "platform/RuntimeEnabledFeatures.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerCacheError.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h"

@@ -41,7 +42,7 @@ bool commonChecks(ScriptState* scriptState, ExceptionState& exceptionState)

void checkCacheQueryOptions(const CacheQueryOptions& options, ExecutionContext* context)

{

- if (options.ignoreSearch())

+ if (!RuntimeEnabledFeatures::cacheIgnoreSearchOptionEnabled() && options.ignoreSearch())

context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Cache.match() does not support 'ignoreSearch' option yet. See http://crbug.com/520784"));

if (options.ignoreMethod())

context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, "Cache.match() does not support 'ignoreMethod' option yet. See http://crbug.com/482256"));