content/browser/cache_storage/cache_storage_cache_unittest.cc - Issue 1578363009: CacheStorage: Add ignoreSearch option to cache.matchAll().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/cache_storage/cache_storage_cache_unittest.cc

Issue 1578363009: CacheStorage: Add ignoreSearch option to cache.matchAll(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/cache_storage/cache_storage_cache.cc ('k') | content/browser/cache_storage/cache_storage_dispatcher_host.cc » ('j') | third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/ignore-search-with-credentials-worker.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/cache_storage/cache_storage_cache_unittest.cc

diff --git a/content/browser/cache_storage/cache_storage_cache_unittest.cc b/content/browser/cache_storage/cache_storage_cache_unittest.cc

index ae9567bca81067d0d3fd24c1720ef6fb8501563e..af789333d72d4713430cbf664cb6e8af93b153ce 100644

--- a/content/browser/cache_storage/cache_storage_cache_unittest.cc

+++ b/content/browser/cache_storage/cache_storage_cache_unittest.cc

@@ -384,9 +384,11 @@ class CacheStorageCacheTest : public testing::Test {

bool MatchAll(scoped_ptr<CacheStorageCache::Responses>* responses,

scoped_ptr<CacheStorageCache::BlobDataHandles>* body_handles) {

base::RunLoop loop;

- cache_->MatchAll(base::Bind(

- &CacheStorageCacheTest::ResponsesAndErrorCallback,

- base::Unretained(this), loop.QuitClosure(), responses, body_handles));

+ cache_->MatchAll(

+ scoped_ptr<ServiceWorkerFetchRequest>(), CacheStorageCacheQueryParams(),

nhiroki 2016/02/10 07:35:32 Can you add unittests for the case where 'ignore_s

zino 2016/02/11 03:35:05 Done.

+ base::Bind(&CacheStorageCacheTest::ResponsesAndErrorCallback,

+ base::Unretained(this), loop.QuitClosure(), responses,

+ body_handles));

loop.Run();

return callback_error_ == CACHE_STORAGE_OK;

}