Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: third_party/WebKit/Source/modules/cachestorage/Cache.cpp

Issue 1578363009: CacheStorage: Add ignoreSearch option to cache.matchAll(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/cachestorage/Cache.h" 5 #include "modules/cachestorage/Cache.h"
6 6
7 #include "bindings/core/v8/CallbackPromiseAdapter.h" 7 #include "bindings/core/v8/CallbackPromiseAdapter.h"
8 #include "bindings/core/v8/ExceptionState.h" 8 #include "bindings/core/v8/ExceptionState.h"
9 #include "bindings/core/v8/ScriptPromiseResolver.h" 9 #include "bindings/core/v8/ScriptPromiseResolver.h"
10 #include "bindings/core/v8/ScriptState.h" 10 #include "bindings/core/v8/ScriptState.h"
11 #include "bindings/core/v8/V8Binding.h" 11 #include "bindings/core/v8/V8Binding.h"
12 #include "bindings/core/v8/V8ThrowException.h" 12 #include "bindings/core/v8/V8ThrowException.h"
13 #include "bindings/modules/v8/V8Response.h" 13 #include "bindings/modules/v8/V8Response.h"
14 #include "core/dom/DOMException.h" 14 #include "core/dom/DOMException.h"
15 #include "core/dom/ExceptionCode.h" 15 #include "core/dom/ExceptionCode.h"
16 #include "core/inspector/ConsoleMessage.h" 16 #include "core/inspector/ConsoleMessage.h"
17 #include "modules/cachestorage/CacheStorageError.h" 17 #include "modules/cachestorage/CacheStorageError.h"
18 #include "modules/fetch/BodyStreamBuffer.h" 18 #include "modules/fetch/BodyStreamBuffer.h"
19 #include "modules/fetch/FetchDataLoader.h" 19 #include "modules/fetch/FetchDataLoader.h"
20 #include "modules/fetch/GlobalFetch.h" 20 #include "modules/fetch/GlobalFetch.h"
21 #include "modules/fetch/Request.h" 21 #include "modules/fetch/Request.h"
22 #include "modules/fetch/Response.h" 22 #include "modules/fetch/Response.h"
23 #include "platform/HTTPNames.h" 23 #include "platform/HTTPNames.h"
24 #include "platform/RuntimeEnabledFeatures.h"
24 #include "public/platform/Platform.h" 25 #include "public/platform/Platform.h"
25 #include "public/platform/WebPassOwnPtr.h" 26 #include "public/platform/WebPassOwnPtr.h"
26 #include "public/platform/modules/serviceworker/WebServiceWorkerCache.h" 27 #include "public/platform/modules/serviceworker/WebServiceWorkerCache.h"
27 28
28 namespace blink { 29 namespace blink {
29 30
30 namespace { 31 namespace {
31 32
32 void checkCacheQueryOptions(const CacheQueryOptions& options, ExecutionContext* context) 33 void checkCacheQueryOptions(const CacheQueryOptions& options, ExecutionContext* context)
33 { 34 {
34 if (options.ignoreSearch()) 35 if (!RuntimeEnabledFeatures::cacheIgnoreSearchOptionEnabled() && options.ign oreSearch())
35 context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, Warni ngMessageLevel, "Cache.match() does not support 'ignoreSearch' option yet. See h ttp://crbug.com/520784")); 36 context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, Warni ngMessageLevel, "Cache.match() does not support 'ignoreSearch' option yet. See h ttp://crbug.com/520784"));
36 if (options.ignoreMethod()) 37 if (options.ignoreMethod())
37 context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, Warni ngMessageLevel, "Cache.match() does not support 'ignoreMethod' option yet. See h ttp://crbug.com/482256")); 38 context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, Warni ngMessageLevel, "Cache.match() does not support 'ignoreMethod' option yet. See h ttp://crbug.com/482256"));
38 if (options.ignoreVary()) 39 if (options.ignoreVary())
39 context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, Warni ngMessageLevel, "Cache.match() does not support 'ignoreVary' option yet. See htt p://crbug.com/499216")); 40 context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, Warni ngMessageLevel, "Cache.match() does not support 'ignoreVary' option yet. See htt p://crbug.com/499216"));
40 } 41 }
41 42
42 // FIXME: Consider using CallbackPromiseAdapter. 43 // FIXME: Consider using CallbackPromiseAdapter.
43 class CacheMatchCallbacks : public WebServiceWorkerCache::CacheMatchCallbacks { 44 class CacheMatchCallbacks : public WebServiceWorkerCache::CacheMatchCallbacks {
44 WTF_MAKE_NONCOPYABLE(CacheMatchCallbacks); 45 WTF_MAKE_NONCOPYABLE(CacheMatchCallbacks);
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 Request* newRequest = Request::create(scriptState, request.getAsUSVString(), exceptionState); 429 Request* newRequest = Request::create(scriptState, request.getAsUSVString(), exceptionState);
429 if (exceptionState.hadException()) 430 if (exceptionState.hadException())
430 return ScriptPromise(); 431 return ScriptPromise();
431 return keysImpl(scriptState, newRequest, options); 432 return keysImpl(scriptState, newRequest, options);
432 } 433 }
433 434
434 // static 435 // static
435 WebServiceWorkerCache::QueryParams Cache::toWebQueryParams(const CacheQueryOptio ns& options) 436 WebServiceWorkerCache::QueryParams Cache::toWebQueryParams(const CacheQueryOptio ns& options)
436 { 437 {
437 WebServiceWorkerCache::QueryParams webQueryParams; 438 WebServiceWorkerCache::QueryParams webQueryParams;
438 webQueryParams.ignoreSearch = options.ignoreSearch(); 439 webQueryParams.ignoreSearch = options.ignoreSearch() && RuntimeEnabledFeatur es::cacheIgnoreSearchOptionEnabled();
439 webQueryParams.ignoreMethod = options.ignoreMethod(); 440 webQueryParams.ignoreMethod = options.ignoreMethod();
440 webQueryParams.ignoreVary = options.ignoreVary(); 441 webQueryParams.ignoreVary = options.ignoreVary();
441 webQueryParams.cacheName = options.cacheName(); 442 webQueryParams.cacheName = options.cacheName();
442 return webQueryParams; 443 return webQueryParams;
443 } 444 }
444 445
445 Cache::Cache(WeakPtrWillBeRawPtr<GlobalFetch::ScopedFetcher> fetcher, PassOwnPtr <WebServiceWorkerCache> webCache) 446 Cache::Cache(WeakPtrWillBeRawPtr<GlobalFetch::ScopedFetcher> fetcher, PassOwnPtr <WebServiceWorkerCache> webCache)
446 : m_scopedFetcher(fetcher) 447 : m_scopedFetcher(fetcher)
447 , m_webCache(webCache) 448 , m_webCache(webCache)
448 { 449 {
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 m_webCache->dispatchKeys(new CacheWithRequestsCallbacks(resolver), 0, toWebQ ueryParams(options)); 583 m_webCache->dispatchKeys(new CacheWithRequestsCallbacks(resolver), 0, toWebQ ueryParams(options));
583 return promise; 584 return promise;
584 } 585 }
585 586
586 WebServiceWorkerCache* Cache::webCache() const 587 WebServiceWorkerCache* Cache::webCache() const
587 { 588 {
588 return m_webCache.get(); 589 return m_webCache.get();
589 } 590 }
590 591
591 } // namespace blink 592 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698