Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1578363007: Re-instate geometry sharing optimization for 'd' on <use>'d <path>s (Closed)

Created:
4 years, 11 months ago by fs
Modified:
4 years, 11 months ago
Reviewers:
pdr., f(malita)
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-instate geometry sharing optimization for 'd' on <use>'d <path>s This adds back the geometry sharing optimization initially added in https://codereview.chromium.org/1425913004 and removed by https://codereview.chromium.org/1439793003. This CL moves the optimization from asPath() to collectStyleForPresentationAttribute(), meaning the optimization only applies to the presentation attribute style (which is equivalent to the old version.) BUG=535429 Committed: https://crrev.com/864121a54e334e9925e6139cb3d8319ef763c002 Cr-Commit-Position: refs/heads/master@{#369473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M third_party/WebKit/Source/core/svg/SVGPathElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.cpp View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fs
4 years, 11 months ago (2016-01-13 20:58:12 UTC) #3
f(malita)
lgtm
4 years, 11 months ago (2016-01-14 13:55:31 UTC) #4
pdr.
On 2016/01/14 at 13:55:31, fmalita wrote: > lgtm Lgtm 2
4 years, 11 months ago (2016-01-14 17:03:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578363007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578363007/1
4 years, 11 months ago (2016-01-14 17:07:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 18:25:40 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 18:27:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/864121a54e334e9925e6139cb3d8319ef763c002
Cr-Commit-Position: refs/heads/master@{#369473}

Powered by Google App Engine
This is Rietveld 408576698