Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1578353003: [MD settings] Appearance settings strings mocks changes (Closed)

Created:
4 years, 11 months ago by dschuyler
Modified:
4 years, 11 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] Appearance settings strings mocks changes This CL changes some UI strings in the Appearance settings to better match the mocks. BUG=531786 Committed: https://crrev.com/7adee77e870572b2270117bde827b4f877187898 Cr-Commit-Position: refs/heads/master@{#369106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/app/settings_strings.grdp View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dschuyler
4 years, 11 months ago (2016-01-12 23:01:27 UTC) #2
dpapad
lgtm
4 years, 11 months ago (2016-01-12 23:13:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578353003/1
4 years, 11 months ago (2016-01-13 02:26:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 03:52:57 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 03:53:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7adee77e870572b2270117bde827b4f877187898
Cr-Commit-Position: refs/heads/master@{#369106}

Powered by Google App Engine
This is Rietveld 408576698