Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1578353002: Pull the Activity context from WindowAndroid if possible (Closed)

Created:
4 years, 11 months ago by Yusuf
Modified:
4 years, 11 months ago
Reviewers:
boliu
CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Pull the Activity context from WindowAndroid if possible WebView uses ContentViewCore's context for displaying dialogs and wraps it at construction time. This change makes sure that if there is an activity that can be reached through WindowAndroid, we use that as the context inside ColorChooser. Also make sure if there is no activity, we dont attempt to create a color chooser and try to show it. Update ActivityWindowAndroid to take a Context type so that in Android WebView, the activity context can remain wrapped. This change is a combination of https://codereview.chromium.org/1419843002 and https://codereview.chromium.org/1572913003 and in general changes WindowAndroid behavior so that a Context reference is kept rather than an Activity reference and makes it possible to use a ContextWrapper. BUG=550410, 570429 R=boliu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e39ed6c6b763d7d3c7b70f68a92054449da15f30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -86 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +10 lines, -11 lines 0 comments Download
M components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +0 lines, -17 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java View 13 chunks +23 lines, -21 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/WindowAndroid.java View 5 chunks +42 lines, -4 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/resources/ResourceManager.java View 2 chunks +29 lines, -9 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/resources/system/SystemResourceLoader.java View 5 chunks +8 lines, -16 lines 0 comments Download
M ui/android/resources/resource_manager_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/android/resources/resource_manager_impl.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/android/resources/resource_manager_impl_unittest.cc View 5 chunks +13 lines, -2 lines 0 comments Download
M ui/android/window_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/android/window_android.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Yusuf
4 years, 11 months ago (2016-01-12 20:27:38 UTC) #2
boliu
lgtm Should keep an eye on the release bots to make sure this builds
4 years, 11 months ago (2016-01-12 20:58:15 UTC) #3
Yusuf
4 years, 11 months ago (2016-01-12 21:30:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e39ed6c6b763d7d3c7b70f68a92054449da15f30.

Powered by Google App Engine
This is Rietveld 408576698